From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Karsten Blees" <karsten.blees@gmail.com>,
"Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Stefan Beller" <sbeller@google.com>,
"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH 82/83] environment: add set_index_file()
Date: Tue, 03 May 2016 08:36:24 -0700 [thread overview]
Message-ID: <xmqqh9efp30n.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1461505189-16234-3-git-send-email-chriscool@tuxfamily.org> (Christian Couder's message of "Sun, 24 Apr 2016 15:39:48 +0200")
Christian Couder <christian.couder@gmail.com> writes:
> +void set_index_file(char *index_file)
> +{
> + git_index_file = index_file;
> +}
What's the rationale for this change, and more importantly, the
ownership rule for the string? When you call this function, does
the caller still own that piece of memory? When you call this
twice, where does the old value go and who is responsible for
taking care of not leaking it?
Cannot guess any of the above with no proposed log message (that
comment applies most of your patches in this series).
next prev parent reply other threads:[~2016-05-03 15:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 13:39 [PATCH 80/83] run-command: make dup_devnull() non static Christian Couder
2016-04-24 13:39 ` [PATCH 81/83] apply: roll back index in case of error Christian Couder
2016-04-25 16:06 ` Johannes Schindelin
2016-05-02 7:07 ` Johannes Schindelin
2016-05-02 7:18 ` Eric Sunshine
2016-05-03 12:57 ` Christian Couder
2016-04-24 13:39 ` [PATCH 82/83] environment: add set_index_file() Christian Couder
2016-05-03 15:36 ` Junio C Hamano [this message]
2016-05-04 11:50 ` Christian Couder
2016-04-24 13:39 ` [PATCH 83/83] builtin/am: use apply api in run_apply() Christian Couder
2016-04-25 15:03 ` Johannes Schindelin
2016-05-05 10:04 ` Christian Couder
2016-04-25 15:05 ` [PATCH 80/83] run-command: make dup_devnull() non static Johannes Schindelin
2016-05-05 9:50 ` Christian Couder
2016-05-05 20:07 ` Johannes Sixt
2016-05-06 13:56 ` Christian Couder
2016-05-06 15:34 ` Johannes Schindelin
2016-05-07 10:12 ` Christian Couder
2016-05-07 12:13 ` Johannes Schindelin
2016-05-07 13:46 ` Christian Couder
2016-05-08 6:33 ` Johannes Schindelin
2016-05-08 10:15 ` Duy Nguyen
2016-05-09 15:05 ` Johannes Schindelin
2016-05-09 17:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh9efp30n.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=karsten.blees@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).