From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] test-line-buffer: simplify command parsing
Date: Fri, 22 Sep 2017 12:47:35 +0900 [thread overview]
Message-ID: <xmqqh8vvl7hk.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170921062242.t63u2gvpysrrmijs@sigill.intra.peff.net> (Jeff King's message of "Thu, 21 Sep 2017 02:22:43 -0400")
Jeff King <peff@peff.net> writes:
> However, each case arm of the switch falls through to the
> one below it. This is pointless (we know that a command
> starting with 'b' does not need to check any of the commands
> in the 'c' block), and it makes gcc's -Wimplicit-fallthrough
> complain.
Wow, this is an embarassment. The code tries to cleverly optimize
it, and then fails miserably.
The updated one reads good. Thanks.
next prev parent reply other threads:[~2017-09-22 3:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 6:20 [PATCH 0/4] appeasing -Wimplicit-fallthrough Jeff King
2017-09-21 6:21 ` [PATCH 1/4] cat-file: handle NULL object_context.path Jeff King
2017-09-22 0:58 ` Jonathan Nieder
2017-09-21 6:22 ` [PATCH 2/4] test-line-buffer: simplify command parsing Jeff King
2017-09-22 3:47 ` Junio C Hamano [this message]
2017-09-21 6:23 ` [PATCH 3/4] curl_trace(): eliminate switch fallthrough Jeff King
2017-09-21 6:25 ` [PATCH 4/4] consistently use "fallthrough" comments in switches Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh8vvl7hk.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).