From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Thomas Gummerer <t.gummerer@gmail.com>,
git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
"Robert P . J . Day" <rpjday@crashcourse.ca>
Subject: Re: [PATCH v3 0/3] deprecate git stash save
Date: Mon, 23 Oct 2017 15:26:11 +0900 [thread overview]
Message-ID: <xmqqh8uqbcsc.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171023051850.vil3p5pmu3jb2a5y@sigill.intra.peff.net> (Jeff King's message of "Mon, 23 Oct 2017 01:18:51 -0400")
Jeff King <peff@peff.net> writes:
> On Mon, Oct 23, 2017 at 10:19:38AM +0900, Junio C Hamano wrote:
>
>> > - This option is deprecated in favour of 'git stash push'.
>> > + This option is deprecated in favour of 'git stash push'. It
>> > + differs from "stash push" in that it cannot take pathspecs,
>> > + and any non-option arguments form the message.
>>
>> Every time I saw this line, I misread s/form/from/ and got
>> confused.
>
> We could reverse the order:
>
> ...and the message is taken from any non-option arguments.
Yeah, that makes it slightly less confusing. Or "any non-option
arguments become the message", perhaps? I dunno.
Let's queue the version as posted; perhaps somebody new comes and
says it is confusing in three months, at which time we may be able
to come up with a better phrasing with a fresh mind ;-)
next prev parent reply other threads:[~2017-10-23 6:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 20:00 [RFC] deprecate git stash save? (was: Re: [PATCH 2/3] http-push: fix construction of hex value from path) Thomas Gummerer
2017-10-05 20:10 ` [PATCH 2/1] mention git stash push first in the man page Thomas Gummerer
2017-10-17 4:14 ` Jeff King
2017-10-17 21:45 ` Thomas Gummerer
2017-10-17 21:47 ` Jeff King
2017-10-19 18:08 ` Thomas Gummerer
2017-10-20 8:04 ` Robert P. J. Day
2017-10-21 6:20 ` Jeff King
2017-10-21 6:43 ` Robert P. J. Day
2017-10-12 0:56 ` [RFC] deprecate git stash save? Junio C Hamano
2017-10-12 11:14 ` Junio C Hamano
2017-10-16 18:19 ` Thomas Gummerer
2017-10-17 4:13 ` [RFC] deprecate git stash save? (was: Re: [PATCH 2/3] http-push: fix construction of hex value from path) Jeff King
2017-10-17 21:47 ` Thomas Gummerer
2017-10-19 18:33 ` [PATCH v2 1/2] replace git stash save with git stash push in the documentation Thomas Gummerer
2017-10-19 18:33 ` [PATCH v2 2/2] mark git stash push deprecated in the man page Thomas Gummerer
2017-10-21 6:28 ` Jeff King
2017-10-22 16:31 ` Thomas Gummerer
2017-10-22 17:04 ` [PATCH v3 0/3] deprecate git stash save Thomas Gummerer
2017-10-22 17:04 ` [PATCH v3 1/3] replace git stash save with git stash push in the documentation Thomas Gummerer
2017-10-22 17:04 ` [PATCH v3 2/3] mark git stash push deprecated in the man page Thomas Gummerer
2017-10-22 17:04 ` [PATCH v3 3/3] stash: remove now superfluos help for "stash push" Thomas Gummerer
2017-10-23 0:39 ` [PATCH v3 0/3] deprecate git stash save Jeff King
2017-10-23 1:19 ` Junio C Hamano
2017-10-23 5:18 ` Jeff King
2017-10-23 6:26 ` Junio C Hamano [this message]
2017-10-23 5:47 ` Robert P. J. Day
2017-10-23 1:32 ` Junio C Hamano
2017-10-21 6:26 ` [PATCH v2 1/2] replace git stash save with git stash push in the documentation Jeff King
2017-10-22 16:28 ` Thomas Gummerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh8uqbcsc.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=rpjday@crashcourse.ca \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).