From: Junio C Hamano <gitster@pobox.com>
To: Max Kirillov <max@max630.net>
Cc: git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH] unpack-trees: do not fail reset because of unmerged skipped entry
Date: Fri, 15 Jun 2018 12:58:40 -0700 [thread overview]
Message-ID: <xmqqh8m3zurz.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180615044251.10597-1-max@max630.net> (Max Kirillov's message of "Fri, 15 Jun 2018 07:42:51 +0300")
Max Kirillov <max@max630.net> writes:
> After modify/delete merge conflict happens in a file skipped by sparse
> checkout, "git reset --merge", which implements the "--abort" actions, and
> "git reset --hard" fail with message "Entry * not uptodate. Cannot update
> sparse checkout." The reason is that the entry is verified in
> apply_sparse_checkout() for being up-to-date even when it has a conflict.
> Checking conflicted entry for being up-to-date is not performed in other
> cases. One obvious reason to not check it is that it is already modified
> by inserting conflict marks.
>
> Fix by not checking conflicted entries before performing reset.
> Also, add test case which verifies the issue is fixed.
I do not know offhand if "reset --merge" should force succeeding in
such a case, but I agree that it is criminal to stop "reset --hard"
with "not uptodate", as the whole point of "hard reset" is to get
rid of the 'not up-to-date' modification.
I guess not may people make serious use of sparsely checked-out
working tree and that is why such a failure is reported this late
after the feature was introduced?
> +test_expect_success 'reset --hard works after the conflict' '
> + git reset --hard
> +'
Do we want to verify the state after the 'hard' reset succeeds as
well? Things like
- all paths in the HEAD and all paths in the index are identical;
- paths that do exist in the working tree are all identical to HEAD
version; and
- paths that do not exist in the working tree are missing due to
the sparse checkout setting (iow, it is a bug if a path that is
outside the "sparse" setting is missing from the working tree).
> +test_expect_success 'setup: conflict back' '
> + ! git merge theirs
> +'
> +
> +test_expect_success 'Merge abort works after the conflict' '
> + git merge --abort
> +'
Likewise here.
> +test_done
> diff --git a/unpack-trees.c b/unpack-trees.c
> index e73745051e..65ae0721a6 100644
> --- a/unpack-trees.c
> +++ b/unpack-trees.c
> @@ -468,7 +468,7 @@ static int apply_sparse_checkout(struct index_state *istate,
> * also stat info may have lost after merged_entry() so calling
> * verify_uptodate() again may fail
> */
> - if (!(ce->ce_flags & CE_UPDATE) && verify_uptodate_sparse(ce, o))
> + if (!(ce->ce_flags & CE_UPDATE) && !(ce->ce_flags & CE_CONFLICTED) && verify_uptodate_sparse(ce, o))
> return -1;
> ce->ce_flags |= CE_WT_REMOVE;
> ce->ce_flags &= ~CE_UPDATE;
Thanks.
next prev parent reply other threads:[~2018-06-15 19:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 4:42 [PATCH] unpack-trees: do not fail reset because of unmerged skipped entry Max Kirillov
2018-06-15 19:58 ` Junio C Hamano [this message]
2018-06-16 8:22 ` Max Kirillov
2018-07-10 19:23 ` Max Kirillov
2018-06-16 5:14 ` Duy Nguyen
2018-07-10 19:21 ` Max Kirillov
2018-07-11 15:25 ` Duy Nguyen
2018-07-11 16:35 ` Junio C Hamano
2018-07-10 19:17 ` [PATCH v2] " Max Kirillov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh8m3zurz.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=max@max630.net \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).