From: Junio C Hamano <gitster@pobox.com>
To: randall.s.becker@rogers.com
Cc: git@vger.kernel.org, "Randall S. Becker" <rsbecker@nexbridge.com>
Subject: Re: [Fix v1] t5403: correct bash ambiguous redirect error in subtest 8 by quoting $GIT_DIR
Date: Fri, 08 Feb 2019 11:55:37 -0800 [thread overview]
Message-ID: <xmqqh8dejbra.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190208113233.14544-1-randall.s.becker@rogers.com> (randall s. becker's message of "Fri, 8 Feb 2019 06:32:33 -0500")
randall.s.becker@rogers.com writes:
> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> The embedded blanks in the full path of the test git repository cased bash
> to generate an ambugious redirect error.
>
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
Thanks.
> t/t5403-post-checkout-hook.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t5403-post-checkout-hook.sh b/t/t5403-post-checkout-hook.sh
> index a539ffc08..a39b3b5c7 100755
> --- a/t/t5403-post-checkout-hook.sh
> +++ b/t/t5403-post-checkout-hook.sh
> @@ -67,7 +67,7 @@ test_expect_success 'post-checkout is triggered on rebase with fast-forward' '
> test_expect_success 'post-checkout hook is triggered by clone' '
> mkdir -p templates/hooks &&
> write_script templates/hooks/post-checkout <<-\EOF &&
> - echo "$@" >$GIT_DIR/post-checkout.args
> + echo "$@" >"$GIT_DIR/post-checkout.args"
> EOF
> git clone --template=templates . clone3 &&
> test -f clone3/.git/post-checkout.args
prev parent reply other threads:[~2019-02-08 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 11:32 [Fix v1] t5403: correct bash ambiguous redirect error in subtest 8 by quoting $GIT_DIR randall.s.becker
2019-02-08 19:55 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh8dejbra.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=randall.s.becker@rogers.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).