From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: randall.s.becker@rogers.com, Git List <git@vger.kernel.org>,
"Randall S. Becker" <rsbecker@nexbridge.com>
Subject: Re: [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes
Date: Tue, 12 Feb 2019 09:18:07 -0800 [thread overview]
Message-ID: <xmqqh8d9diy8.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPig+cTMoYMmnHVuay_4RGr_FN-HWC1tN4TPDsNM4vKCH3GzXw@mail.gmail.com> (Eric Sunshine's message of "Sat, 9 Feb 2019 21:07:47 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Sat, Feb 9, 2019 at 2:00 PM <randall.s.becker@rogers.com> wrote:
>> This change removes the dependency on /dev/zero with generate_zero_bytes
>> appending NUL values to blocks generating wrong signatures for test cases.
>
> This commit message says what the patch does but not _why_. At
> minimum, it should explain that /dev/zero is not available on all
> platforms, therefore, not portable, and (perhaps) cite NonStop as an
> example.
Does sombody want to do the honors? [PATCH 1/3] would become wasted
effort until that happens. On the other hand, if this is not urgent
(it is only urgent for those without /dev/zero, and to others it may
be distraction/disruption this close to the final release to add
increased risk of fat finger mistakes), obviously I can wait.
>> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
>> ---
>> diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh
>> @@ -383,7 +383,7 @@ corrupt_graph_and_verify() {
>> - dd if=/dev/zero of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" count=$(($orig_size - $zero_pos)) &&
>> + generate_zero_bytes $(($orig_size - $zero_pos)) >> "$objdir/info/commit-graph" &&
The original says "skip to the $zero_pos location in an existing
info/commit-graph file, and overwrite its existing contents up to
the $orig_size location with NULs".
If I recall the implementation of generate_zero_bytes in [PATCH 1/3]
correctly, it just generated stream of NULs of given number of bytes.
The only reason why this rewrite is not wrong is because the
previous line (omitted in your quote) truncates the file to
$zero_pos. That is a bit tricky ;-).
next prev parent reply other threads:[~2019-02-12 17:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 18:59 [Patch v1 0/3] 2.21.0-rc0 test fixes resulting from use of /dev/zero randall.s.becker
2019-02-09 18:59 ` [Patch v1 1/3] test-lib-functions.sh: add generate_zero_bytes function randall.s.becker
2019-02-10 2:05 ` Eric Sunshine
2019-02-10 19:19 ` Randall S. Becker
2019-02-12 0:37 ` Jeff King
2019-02-12 1:17 ` Eric Sunshine
2019-02-12 2:47 ` randall.s.becker
2019-02-09 18:59 ` [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes randall.s.becker
2019-02-10 2:07 ` Eric Sunshine
2019-02-12 17:18 ` Junio C Hamano [this message]
2019-02-13 17:25 ` Junio C Hamano
2019-02-13 18:18 ` Randall S. Becker
2019-02-13 21:00 ` Junio C Hamano
2019-02-13 21:03 ` Randall S. Becker
2019-02-09 18:59 ` [Patch v1 3/3] t5562: replace /dev/zero with a pipe from generate_zero_bytes randall.s.becker
2019-02-10 2:12 ` Eric Sunshine
2019-02-12 17:24 ` Junio C Hamano
2019-02-12 20:50 ` Johannes Sixt
2019-02-13 17:26 ` Junio C Hamano
2019-02-15 16:42 ` [PATCH] t5562: do not depend on /dev/zero Max Kirillov
2019-02-15 17:13 ` Randall S. Becker
2019-02-15 18:00 ` Junio C Hamano
2019-02-15 18:10 ` Randall S. Becker
2019-02-15 18:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh8d9diy8.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=randall.s.becker@rogers.com \
--cc=rsbecker@nexbridge.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).