From: Junio C Hamano <firstname.lastname@example.org>
To: Miriam Rubio <email@example.com>
Cc: firstname.lastname@example.org, Tanushree Tumane <email@example.com>,
Christian Couder <firstname.lastname@example.org>
Subject: Re: [Outreachy] [PATCH] bisect--helper: change `retval` to `res`
Date: Mon, 16 Dec 2019 11:08:54 -0800 [thread overview]
Message-ID: <email@example.com> (raw)
In-Reply-To: <firstname.lastname@example.org> (Miriam Rubio's message of "Mon, 16 Dec 2019 12:12:46 +0100")
Miriam Rubio <email@example.com> writes:
> From: Tanushree Tumane <firstname.lastname@example.org>
> Convert of variable `retval` to `res` make `bisect--helper.c`
> more consistent.
> Now, 110 ocurrences of `res` in file and zero `retval` occurrences.
And why is this a desirable change, not merely a distracting code
IOW, are there other changes that build on this change that benefits
from the fact that the variable that holds the value to be returned
is always called "res" after this patch gets applied?
FWIW, I actually think "retval" would be a more appropriate name for
the variable that holds the value to be returned than "res", but it
is not worth the churn either way---I see this more as "once the
code is written one way, it is not worth wasting bits and brain
cycles to change it" kind of issue.
Unless there are other valid reasons to do this change, that is.
prev parent reply other threads:[~2019-12-16 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 11:12 [Outreachy] [PATCH] bisect--helper: change `retval` to `res` Miriam Rubio
2019-12-16 19:08 ` Junio C Hamano [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).