From: Junio C Hamano <gitster@pobox.com>
To: Philip Oakley <philipoakley@iee.email>
Cc: Ed Avis <ed.avis@qmaw.com>, "git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git log --name-only improvement: show old file name in rename
Date: Fri, 12 Jun 2020 10:03:02 -0700 [thread overview]
Message-ID: <xmqqh7vg2p4p.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <25ca66fb-82bc-7278-90e9-5e1999593068@iee.email> (Philip Oakley's message of "Fri, 12 Jun 2020 15:18:49 +0100")
Philip Oakley <philipoakley@iee.email> writes:
> @Ed
> On 12/06/2020 00:16, Junio C Hamano wrote:
>> Ed Avis <ed.avis@qmaw.com> writes:
>>
>>> The git-log manual page says
>>>
>>> --name-only
>>> Show only names of changed files.
>>>
>>> But when a file has been renamed, only the new name is printed, not the
>>> old. I think it would be more useful and more correct to print both
>>> names.
> Was this a concern that the manual did not clarify which name (old or
> new) was being reported?
Good point.
I am not Ed so I cannot give an answer to that question, but if we
do not document what name is listed in the output, we definitely
should.
Thanks.
next prev parent reply other threads:[~2020-06-12 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 11:19 git log --name-only improvement: show old file name in rename Ed Avis
2020-06-11 23:16 ` Junio C Hamano
2020-06-12 14:18 ` Philip Oakley
2020-06-12 17:03 ` Junio C Hamano [this message]
2020-06-15 7:36 ` Ed Avis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7vg2p4p.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=ed.avis@qmaw.com \
--cc=git@vger.kernel.org \
--cc=philipoakley@iee.email \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).