From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id ACFA21F66E for ; Thu, 27 Aug 2020 04:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726070AbgH0Eb2 (ORCPT ); Thu, 27 Aug 2020 00:31:28 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:63507 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbgH0Eb1 (ORCPT ); Thu, 27 Aug 2020 00:31:27 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 5F2F26DE13; Thu, 27 Aug 2020 00:31:25 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=dBDGpydfZn1sPZFe082eASR2rkk=; b=oOjqCT 8XQcxKeRDalGWXbf/4GuPpbBvNvSyOv2CI+nN4tIsz8uCG1/n3u/Kg9TKQWnte2y 3si0kdjxc25jS13/UqzXchvCA39HtGWgeVClezy7H3kzs3bX/OQJpFVnvHK+98ns OMM/7sAOVlGiBo+p9OnLNzmvJJJhK2RxNKyAM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=avxAOAcUpyH51hmu7A9IGoIrBlULfAGX qblL9PZeJOPWkPwF3CdIzBm6pqU6X+76epOHEAatt2sledhMFYtmfzDwENg6Tgrl qLhyWSiajf9hu3UqzyYMbIcuSsjHjAZ1MHByV6Xvl/ClO7v3zIFFskBm6PoadZOF GM65X58xYzw= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 579FA6DE12; Thu, 27 Aug 2020 00:31:25 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id D639A6DE11; Thu, 27 Aug 2020 00:31:24 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: git@vger.kernel.org Subject: Re: [PATCH v2 3/2] credential-cache: use child_process.args References: <20200826194650.4031087-1-gitster@pobox.com> <20200826194650.4031087-3-gitster@pobox.com> <20200827041328.GA3346457@coredump.intra.peff.net> Date: Wed, 26 Aug 2020 21:31:24 -0700 In-Reply-To: <20200827041328.GA3346457@coredump.intra.peff.net> (Jeff King's message of "Thu, 27 Aug 2020 00:13:28 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 2A8F795C-E81E-11EA-8BB3-2F5D23BA3BAF-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: > Yep, this makes sense. I don't recall any reason to use the dashed form > back then, but probably it was just that I knew it was a separate > program. Doing it this way will mean an extra parent "git" process > hanging around, but I don't think it's that big a deal. We never try to > kill it by PID, etc (instead we connect to the socket and ask it to > exit). And anyway, it is becoming a builtin in a parallel topic, so that > extra process will go away. :) Yeah, this was discovered when I tentatively merged that "don't run built-in as git-foo" to the tip of seen. Without your slimmed-down topic, it wouldn't have been caught. Likewise for remote-ext.