From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: "Rafael Silva" <rafaeloliveira.cs@gmail.com>,
"Derrick Stolee" <dstolee@microsoft.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Josh Steadmon" <steadmon@google.com>
Subject: Re: [PATCH v2 1/1] maintenance: fix SEGFAULT when no repository
Date: Tue, 08 Dec 2020 14:17:32 -0800 [thread overview]
Message-ID: <xmqqh7ow54eb.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <xmqqsg8g559i.fsf@gitster.c.googlers.com> (Junio C. Hamano's message of "Tue, 08 Dec 2020 13:58:49 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Josh Steadmon <steadmon@google.com> writes:
>
>> Caught a typo here, sending this as a squash patch since it's already in
>> next:
>
> The breakage and the fix looks obvious to me, but...
>
> How did CI allow 'next' to pass with such a typo, I wonder?
> Moreover, my pre-push tests of all the integration branches
> I didn't notice this to fail, but I cannot see how it could
> have been succeeded. Puzzled...
That is because of this:
$ (sh t7900-maintenance.sh 2>&1; echo $?) | tail -5
ok 25 - register preserves existing strategy
t7900-maintenance.sh: line 444: test_execpt_success: command not found
# passed all 25 test(s)
1..25
0
The story is the same with prove.
$ prove t7900-maintenance-sh
t7900-maintenance.sh .. 24/? t7900-maintenance.sh: line 444: test_execpt_success: command not found
t7900-maintenance.sh .. ok
All tests successful.
Files=1, Tests=25, 2 wallclock secs ( 0.02 usr 0.01 sys + 0.97 cusr 0.97 csys = 1.97 CPU)
Result: PASS
Since this typo appeared immediately before test_done, we _could_
improve test_done to pay attention to $? when it starts (and in a
similar fashion, we _could_ also check $? at the beginning of the
test_expect_* for the previous step), but I do not think that is a
good approach that would scale well. There are legitimate reasons
we have to write things other than test_expect_* at the top level
of the script (e.g. test helper function may have to be defined to
be shared amongst the test pieces in the same script).
I wonder if it is a good direction to go to run the tests with the
"set -e" option on, and accept its peculiarities.
next prev parent reply other threads:[~2020-12-08 22:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 16:44 [PATCH 0/1] maintenance: Fix a SEGFAULT when no repository when running git maintenance run/start Rafael Silva
2020-11-24 16:44 ` [PATCH 1/1] maintenance: fix a SEGFAULT when no repository Rafael Silva
2020-11-24 17:22 ` Derrick Stolee
2020-11-24 21:48 ` Junio C Hamano
2020-11-24 21:59 ` Derrick Stolee
2020-11-26 8:22 ` Rafael Silva
2020-11-26 11:21 ` Derrick Stolee
2020-11-24 17:24 ` Eric Sunshine
2020-11-24 19:14 ` SZEDER Gábor
2020-11-24 19:34 ` Eric Sunshine
2020-11-26 7:13 ` Rafael Silva
2020-11-24 19:03 ` Martin Ågren
2020-11-26 7:07 ` Rafael Silva
2020-11-26 20:41 ` [PATCH v2 0/1] maintenance: Fix SEGFAULT when running outside of a repository Rafael Silva
2020-11-26 20:41 ` [PATCH v2 1/1] maintenance: fix SEGFAULT when no repository Rafael Silva
2020-11-27 20:43 ` Derrick Stolee
2020-12-08 20:12 ` Josh Steadmon
2020-12-08 21:58 ` Junio C Hamano
2020-12-08 22:17 ` Junio C Hamano [this message]
2020-12-24 8:12 ` Christian Couder
2020-12-24 14:14 ` Junio C Hamano
2020-12-09 9:29 ` Rafael Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7ow54eb.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=pclouds@gmail.com \
--cc=rafaeloliveira.cs@gmail.com \
--cc=steadmon@google.com \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).