git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH] SubmittingPatches: tighten wording on "sign-off" procedure
Date: Mon, 28 Dec 2020 02:39:54 -0800	[thread overview]
Message-ID: <xmqqh7o6jjt1.fsf@gitster.c.googlers.com> (raw)

The text says "if you can certify DCO then you add a Singed-off-by
trailer".  But it does not say anything about people who cannot
certify.  A natural reading may be that if you cannot certify, you
do not add the trailer, but it shouldn't hurt to be overly explicit.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

 Documentation/SubmittingPatches | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git c/Documentation/SubmittingPatches w/Documentation/SubmittingPatches
index d12094bac5..b091730771 100644
--- c/Documentation/SubmittingPatches
+++ w/Documentation/SubmittingPatches
@@ -307,35 +307,35 @@ wrote the patch or have the right to pass it on under the same license
 as ours, by "signing off" your patch.  Without sign-off, we cannot
 accept your patches.
 
-If you can certify the below D-C-O:
+If (and only if) you can certify the below D-C-O:
 
 [[dco]]
 .Developer's Certificate of Origin 1.1
 ____
 By making a contribution to this project, I certify that:

 a. The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

 b. The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

 c. The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

 d. I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
 ____

 you add a "Signed-off-by" trailer to your commit, that looks like
 this:

             reply	other threads:[~2020-12-28 10:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 10:39 Junio C Hamano [this message]
2020-12-28 14:09 ` [PATCH] SubmittingPatches: tighten wording on "sign-off" procedure Felipe Contreras
2020-12-28 19:19   ` Junio C Hamano
2020-12-28 15:19 ` Derrick Stolee
2021-01-07 23:38 ` [PATCH v2] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh7o6jjt1.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).