From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: "Phil Hord" <phil.hord@gmail.com>, Git <git@vger.kernel.org>,
"Martin Ågren" <martin.agren@gmail.com>
Subject: Re: [PATCH v2] use delete_refs when deleting tags or branches
Date: Fri, 15 Jan 2021 12:06:11 -0800 [thread overview]
Message-ID: <xmqqh7nirmmk.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CABPp-BEUPH5Yc08uDehAXNQ5-3fJ9YeW0xscVBR45hniDe+HEg@mail.gmail.com> (Elijah Newren's message of "Fri, 15 Jan 2021 10:43:07 -0800")
Elijah Newren <newren@gmail.com> writes:
> Overall, I like the patch. Peff commented on v1 that the basic idea
> (use the part of the refs API that batches operations) is the right
> thing to do.
I concur; I agree with the general direction.
Where do we reject branch deletion based on the merged-ness? When
we ask to delete three branches and one is not merged yet and cannot
be removed (let's say we are not "--force"ing) but the other two are
OK to remove, we do want the other two branches to go. I didn't
check what the patch does with respect to this point, but as long as
the updated code does not make it "all or none", it would be great.
> I would say Reviewed-by, but I'd like to get Junio's comments on the
> return code and minor race.
It would have to wait a bit more. Thanks for a review.
next prev parent reply other threads:[~2021-01-15 20:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 2:49 [PATCH v2] use delete_refs when deleting tags or branches Phil Hord
[not found] ` <CABURp0rtkmo7MSSCVrdNXT0UzV9XqV_kXOGkC23C+_vMENNJUg@mail.gmail.com>
2021-01-15 18:43 ` Elijah Newren
2021-01-15 20:06 ` Junio C Hamano [this message]
2021-01-15 22:04 ` Junio C Hamano
2021-01-16 2:27 ` Phil Hord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7nirmmk.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=newren@gmail.com \
--cc=phil.hord@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).