From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] test-lib: allow test snippets as here-docs
Date: Fri, 09 Apr 2021 17:57:10 -0700 [thread overview]
Message-ID: <xmqqh7kfklcp.fsf@gitster.g> (raw)
In-Reply-To: <xmqqtuofkqxu.fsf@gitster.g> (Junio C. Hamano's message of "Fri, 09 Apr 2021 15:56:29 -0700")
Junio C Hamano <gitster@pobox.com> writes:
>> + # start with a newline, to match hanging newline from open-quote style
>> + eval "$1=\$LF"
>> + local test_line
>> + while IFS= read -r test_line
>> + do
>> + eval "$1=\${$1}\${test_line}\${LF}"
>> + done
>
> I wonder if we can do this without relying on "read -r" (which I
> distrust, perhaps out of superstition)? Perhaps by slurping the
> whole thing with "$(cat)"?
Meaning, something along this line...
----- >8 --------- >8 --------- >8 --------- >8 ----
#!/bin/sh
LF='
'
ttt () {
eval "$1"='$LF$(cat)'
}
ttt script <<\EOT
a
b
EOT
echo "<<<$script>>>"
----- 8< --------- 8< --------- 8< --------- 8< ----
next prev parent reply other threads:[~2021-04-10 0:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 22:26 [RFC/PATCH 0/2] here-doc test bodies Jeff King
2021-04-09 22:28 ` [PATCH 1/2] test-lib: allow test snippets as here-docs Jeff King
2021-04-09 22:30 ` Jeff King
2021-04-09 22:56 ` Junio C Hamano
2021-04-10 0:57 ` Junio C Hamano [this message]
2021-04-10 1:26 ` Jeff King
2021-04-10 8:30 ` Ævar Arnfjörð Bjarmason
2021-04-09 22:28 ` [PATCH 2/2] t1404: convert to here-doc test bodies Jeff King
2021-04-10 1:03 ` [RFC/PATCH 0/2] " Derrick Stolee
2021-04-10 1:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7kfklcp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).