From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS53758 23.128.96.0/24
X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by dcvr.yhbt.net (Postfix) with ESMTP id 285841F5AE
	for <e@yhbt.net>; Thu, 29 Apr 2021 01:38:00 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231874AbhD2Bik (ORCPT <rfc822;e@yhbt.net>);
        Wed, 28 Apr 2021 21:38:40 -0400
Received: from pb-smtp20.pobox.com ([173.228.157.52]:59268 "EHLO
        pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229888AbhD2Bij (ORCPT <rfc822;git@vger.kernel.org>);
        Wed, 28 Apr 2021 21:38:39 -0400
Received: from pb-smtp20.pobox.com (unknown [127.0.0.1])
        by pb-smtp20.pobox.com (Postfix) with ESMTP id E439612C259;
        Wed, 28 Apr 2021 21:37:53 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=MKjZAZdFUUbkHt2Pb6wkNKrlEj9+hQ4Ms04Ath
        c0NI0=; b=wXR7MaBGQZP8TsGrsFCYo3zMcv4/1NBzHM6xql04VXHR6OUeUCPdnY
        z5CN+2U3a1lTC9vKgTHvm5zLL0lTrmZ5BY/v4s8rWoqZpLsLcxN4Vwf9WMLY7wZq
        ub5ojmPhSQi2z/PksvUniadE5HX06DFmQeHvo33w7QTO91GNaLsHw=
Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1])
        by pb-smtp20.pobox.com (Postfix) with ESMTP id DC95112C258;
        Wed, 28 Apr 2021 21:37:53 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [34.74.119.39])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 2319412C256;
        Wed, 28 Apr 2021 21:37:51 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Jeff King <peff@peff.net>
Cc:     David Emett <dave@sp4m.net>, git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] prune: save reachable-from-recent objects with
 bitmaps
References: <YImCNXC5DUvy5gT8@coredump.intra.peff.net>
        <YImCcxVq6AWjtv8k@coredump.intra.peff.net>
Date:   Thu, 29 Apr 2021 10:37:49 +0900
In-Reply-To: <YImCcxVq6AWjtv8k@coredump.intra.peff.net> (Jeff King's message
        of "Wed, 28 Apr 2021 11:42:43 -0400")
Message-ID: <xmqqh7jpan0y.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 82B25D60-A88B-11EB-BCC3-E43E2BB96649-77302942!pb-smtp20.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Jeff King <peff@peff.net> writes:

> -for repack in '' true; do
> -	title=${repack:+repack}
> -	title=${title:-loose}
> -
> +for title in loose repack bitmap; do
>  	test_expect_success "make repo completely empty ($title)" '
>  		rm -rf .git &&
>  		git init

Just this part alone is worth the update ;-) It was not even clear
what "repack" meant in the old loop, or what the significance of
setting it to "true" (as opposed to say "false").

Of course, the early return in the code removed by this patch
explains how the bug happened.  Will queue; thanks.