From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: David Emett <dave@sp4m.net>, git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] prune: save reachable-from-recent objects with bitmaps
Date: Thu, 29 Apr 2021 10:37:49 +0900 [thread overview]
Message-ID: <xmqqh7jpan0y.fsf@gitster.g> (raw)
In-Reply-To: <YImCcxVq6AWjtv8k@coredump.intra.peff.net> (Jeff King's message of "Wed, 28 Apr 2021 11:42:43 -0400")
Jeff King <peff@peff.net> writes:
> -for repack in '' true; do
> - title=${repack:+repack}
> - title=${title:-loose}
> -
> +for title in loose repack bitmap; do
> test_expect_success "make repo completely empty ($title)" '
> rm -rf .git &&
> git init
Just this part alone is worth the update ;-) It was not even clear
what "repack" meant in the old loop, or what the significance of
setting it to "true" (as opposed to say "false").
Of course, the early return in the code removed by this patch
explains how the bug happened. Will queue; thanks.
prev parent reply other threads:[~2021-04-29 1:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 10:45 Two issues with mark_reachable_objects David Emett
2021-04-27 14:41 ` Jeff King
2021-04-27 15:13 ` Jeff King
2021-04-27 15:43 ` [PATCH] prune: save reachable-from-recent objects with bitmaps Jeff King
2021-04-28 12:20 ` David Emett
2021-04-28 15:13 ` Jeff King
2021-04-28 15:41 ` [PATCH v2 0/2] " Jeff King
2021-04-28 15:42 ` [PATCH v2 1/2] pack-bitmap: clean up include_check after use Jeff King
2021-04-28 15:42 ` [PATCH v2 2/2] prune: save reachable-from-recent objects with bitmaps Jeff King
2021-04-29 1:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7jpan0y.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dave@sp4m.net \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).