From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 697161F953 for ; Thu, 16 Dec 2021 21:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237319AbhLPV7o (ORCPT ); Thu, 16 Dec 2021 16:59:44 -0500 Received: from pb-smtp21.pobox.com ([173.228.157.53]:61770 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234459AbhLPV7o (ORCPT ); Thu, 16 Dec 2021 16:59:44 -0500 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 3F6B9178529; Thu, 16 Dec 2021 16:59:44 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=IEimzFIdgHNN wRpDQGCPocbliWnqN2t3LJEdfGKqbno=; b=kDK7sY4RqDqAcAixn6VJZwxjrWo9 V8YBRkbduonSeuUhaGGlA4vVwlJumyWXIwnj4GVyKQlCBKU3TmkgeoGZgUw8DCBK NpNJbytmR2pnlWXER80ZNJnW2qYHtmZ+6AfzymdyPwCEdnk9BtqtWJ4UuF3XLzoB 9Hkg6SXg86k+AIk= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 37EA0178528; Thu, 16 Dec 2021 16:59:44 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 94580178525; Thu, 16 Dec 2021 16:59:40 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?TMOpbmHDr2M=?= Huard Cc: git@vger.kernel.org, Martin =?utf-8?Q?=C3=85gren?= Subject: Re: [PATCH 0/1] grep: align default colors with GNU grep ones References: <20211216115622.85506-1-lenaic@lhuard.fr> Date: Thu, 16 Dec 2021 13:59:39 -0800 In-Reply-To: <20211216115622.85506-1-lenaic@lhuard.fr> (=?utf-8?B?IkzDqW5h?= =?utf-8?B?w69j?= Huard"'s message of "Thu, 16 Dec 2021 12:56:21 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 77F716E0-5EBB-11EC-8BD2-CBA7845BAAA9-77302942!pb-smtp21.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org L=C3=A9na=C3=AFc Huard writes: > git-grep shares a lot of options with the standard grep tool. > Like GNU grep, it has coloring options to highlight the matching text. > And like it, it has options to customize the various colored parts. > > This patch updates the default git-grep colors to make them match the > GNU grep default ones [1]. > > It was possible to get the same result by setting the various `color.gr= ep.` > options, but this patch makes `git grep --color` share the same color s= cheme as > `grep --color` by default without any user configuration. I am not a huge fan of adjusting our defaults to other people's default, since it will lead do an inevitable "Why don't they adjust to match ours?" question, plus "We've been happily using the default coloring, and you suddenly changed it to something ugly. We want our color back and we do not care that now you match what GNU does". The UI color choice is so personal, which does not help us either. Having said that, I'll keep an eye on what others say on this thread. Thanks.