From: Junio C Hamano <gitster@pobox.com>
To: "Sheepolution via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Sheepolution <danielhaazen@hotmail.com>
Subject: Re: [PATCH] Fix word "does" sticking to "not" by adding space
Date: Tue, 20 Dec 2022 09:28:27 +0900 [thread overview]
Message-ID: <xmqqh6xq2a1g.fsf@gitster.g> (raw)
In-Reply-To: <pull.1393.git.git.1671416810927.gitgitgadget@gmail.com> (Sheepolution via GitGitGadget's message of "Mon, 19 Dec 2022 02:26:50 +0000")
"Sheepolution via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Subject: Re: [PATCH] Fix word "does" sticking to "not" by adding space
Not incorrect per-se, but the above fails to say a more important
thing---where does the typo appear?
Subject: [PATCH] mingw: fix typo in an error message from ownership check
or something, perhaps.
> From: =?UTF-8?q?Dani=C3=ABl=20Haazen?= <danielhaazen@hotmail.com>
Here is where the proposed log message goes, not ...
> Signed-off-by: Daniël Haazen <danielhaazen@hotmail.com>
> ---
> git: fix word "does" sticking to "not" in message
>
> When a repository is on a FAT32 file system it will send a message to
> the user explaining they should use git config --global --add
> safe.directory. To prevent a long line in the file the message is made
> up of two string literals. In this change the first literal has a space
> added to it to fix the issue that the last and the first word of the two
> literals stick together like the example image below.
... here.
When a repository is on a FAT32 file system it will send a
message that the path ownership cannot be determined. Fix a
typo in the message.
should be sufficient.
> diff --git a/compat/mingw.c b/compat/mingw.c
> index d614f156df1..af397e68a1d 100644
> --- a/compat/mingw.c
> +++ b/compat/mingw.c
> @@ -2752,7 +2752,7 @@ int is_path_owned_by_current_sid(const char *path, struct strbuf *report)
> /*
> * On FAT32 volumes, ownership is not actually recorded.
> */
> - strbuf_addf(report, "'%s' is on a file system that does"
> + strbuf_addf(report, "'%s' is on a file system that does "
> "not record ownership\n", path);
Thanks for spotting the mistake. Very much appreciated.
prev parent reply other threads:[~2022-12-20 0:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 2:26 [PATCH] Fix word "does" sticking to "not" by adding space Sheepolution via GitGitGadget
2022-12-20 0:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh6xq2a1g.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=danielhaazen@hotmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).