From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id B9E221F428 for ; Thu, 23 Mar 2023 16:06:21 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=CqXoT5wj; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230302AbjCWQGS (ORCPT ); Thu, 23 Mar 2023 12:06:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231387AbjCWQGR (ORCPT ); Thu, 23 Mar 2023 12:06:17 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6688731BDD for ; Thu, 23 Mar 2023 09:06:16 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id a16so17557971pjs.4 for ; Thu, 23 Mar 2023 09:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679587576; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=K/SyXYX4utvGsmsmALLOP3gNv86SIXSemxuDrjWgF7Y=; b=CqXoT5wjFtmxasVsAXR0mgIsXNeFQe1oYpTYvZswb8dvncCMhOkXnf+sxaDhR+e9eb uPc5xM83kwAWaa8Rp3jCxWoSeT1nAI3L0Djhpl1L7FTHATi4dsTp5vytOJzw2RA1mfzR GhQOVLYE5ydoBRto/lK917Epwbf6OoTW8beAGnv4A+RVFLZScEzULt7uQ9+R+8wlB3Mb iL2wgqxCBfZg2RKp8SIMxZ6jtnqqr+GfgfF+C4ka4OYE+6VYkKQRh1hC4Y7gcXsKn3YO U23EJqx50Ufmeuj7dqbiM7e5FI+aVc5f/+n9w6Y+C255Xxgfpba8x/Dm6vo4MmxieyAp SYOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679587576; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=K/SyXYX4utvGsmsmALLOP3gNv86SIXSemxuDrjWgF7Y=; b=kOiZIkB55JqLVHS0sDLrDfVez3vyhca+ImsqNL5Ze6T9PwqyZuC/uQD1LykFzcgr32 NhHVG1gTH6EDSq79G/CdmMF4Lq4Kt4tu0Zza8d9jvNLvCNOmhRl6fBKOJ3zQV4hcD4nh jjT7BpVKMgDTe1jwkaRYo8YGJi3QY4NLFC4SXbLqC9uSInsjph2DzNQ8WoPFweX+rgHd VMimY1K4qo5Ulf27qX8S8luk+QNhTbEbvei0czR2R7PWZxF3RRgtDaq1R5dg4tCD4Mdz KRrisNKoNpq3pGZVN3VzmlxTJMzOV/JEHzilxT3YrV8dyGCPKR9gfDZOxqtfyjHnRTWJ CW8A== X-Gm-Message-State: AO0yUKUxgSw0lKzXyIupWiLh2khD1IfZP24CUbdUQu7y4nH281szAjav n9DG7byfSo56TUdCrR8rDtg= X-Google-Smtp-Source: AK7set+fWoT8qTpFUerXw3CmhWUqj22jSetj/VVPAWSK2QdbT3rctaArfFuLqAcCRPJJHOHE+JMkjg== X-Received: by 2002:a17:903:27c4:b0:19e:8088:b852 with SMTP id km4-20020a17090327c400b0019e8088b852mr6105982plb.10.1679587575566; Thu, 23 Mar 2023 09:06:15 -0700 (PDT) Received: from localhost (83.92.168.34.bc.googleusercontent.com. [34.168.92.83]) by smtp.gmail.com with ESMTPSA id f7-20020a170902860700b001a1d4a985eesm7497890plo.228.2023.03.23.09.06.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 09:06:15 -0700 (PDT) Sender: Junio C Hamano From: Junio C Hamano To: Jeff Hostetler Cc: Johannes Schindelin via GitGitGadget , git@vger.kernel.org, Johannes Schindelin Subject: Re: [PATCH 2/4] split-index; stop abusing the `base_oid` to strip the "link" extension References: Date: Thu, 23 Mar 2023 09:06:15 -0700 In-Reply-To: (Jeff Hostetler's message of "Thu, 23 Mar 2023 09:59:15 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff Hostetler writes: >>> +enum strip_extensions { >>> + WRITE_ALL_EXTENSIONS = 0, >>> + STRIP_ALL_EXTENSIONS = 1, >>> + STRIP_LINK_EXTENSION_ONLY = 2 >>> +}; >> We do not need to spell out the specific values for this enum; the >> users' (i.e. the callers of do_write_index()) sole requirement is >> for these symbols to have different values. > > There are several calls to do_write_locked_index() that pass 0 or 1 > as the new final arg. If we update them to use these enum values, > then we don't need integer values here. Good eyes. Yes, the new caller that selectively passes STRIP_LINK_EXTENSION_ONLY should pass WRITE_ALL_EXTENSIONS, not 0, on the other side of ?: as you pointed out. Thanks.