From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [RFC/PATCH] clone: make 'git clone -c remote.origin.fetch=<refspec>' work
Date: Sun, 06 Mar 2016 17:36:04 -0800 [thread overview]
Message-ID: <xmqqfuw3rrwb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1457313062-10073-1-git-send-email-szeder@ira.uka.de> ("SZEDER Gábor"'s message of "Mon, 7 Mar 2016 02:11:02 +0100")
SZEDER Gábor <szeder@ira.uka.de> writes:
> Check whether there are any relevant configured fetch refspecs and
> take those into account during the initial fetch, unless running 'git
> clone --single-branch'.
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
> ---
Even though I think the original description did not mean to include
the fetch refspecs when it talked about configuration taking effect,
I think what this change wants to do probably makes sense.
>
> I'm unsure what to do with the '-c <fetch-refspec> --single-branch'
> combination: it doesn't really make sense to me and can't imagaine a
> use case where it would be useful... but perhaps I just lack
> imagination on this Sunday night. Hence the RFC.
My knee-jerk reaction is to change the last paragraph of your log
message to read more like
Always read the fetch refspecs from the newly created config
file, and use that for the initial fetching.
and do so even when running with "--single-branch".
next prev parent reply other threads:[~2016-03-07 1:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 1:11 [RFC/PATCH] clone: make 'git clone -c remote.origin.fetch=<refspec>' work SZEDER Gábor
2016-03-07 1:36 ` Junio C Hamano [this message]
2016-03-07 15:19 ` SZEDER Gábor
2016-03-07 15:33 ` Jeff King
2016-03-07 20:01 ` Junio C Hamano
2016-03-30 14:53 ` [PATCH v2] clone: respect configured fetch respecs during initial fetch SZEDER Gábor
2016-03-31 16:15 ` Junio C Hamano
2016-03-31 18:56 ` Junio C Hamano
2016-03-31 20:50 ` SZEDER Gábor
2016-03-31 22:44 ` Junio C Hamano
2016-04-01 4:20 ` SZEDER Gábor
2016-04-01 0:30 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfuw3rrwb.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).