From: Junio C Hamano <gitster@pobox.com>
To: Daniel Ferreira <bnmvco@gmail.com>
Cc: git@vger.kernel.org, sbeller@google.com, pclouds@gmail.com,
mhagger@alum.mit.edu
Subject: Re: [PATCH v10 4/5] dir_iterator: rewrite state machine model
Date: Wed, 19 Apr 2017 20:30:58 -0700 [thread overview]
Message-ID: <xmqqfuh3ah71.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1492607652-36341-5-git-send-email-bnmvco@gmail.com> (Daniel Ferreira's message of "Wed, 19 Apr 2017 10:14:11 -0300")
Daniel Ferreira <bnmvco@gmail.com> writes:
> diff --git a/t/t0065-dir-iterator.sh b/t/t0065-dir-iterator.sh
> index 46e5ce5..4c6632f 100755
> --- a/t/t0065-dir-iterator.sh
> +++ b/t/t0065-dir-iterator.sh
> @@ -15,31 +15,41 @@ test_expect_success 'setup' '
> >dir/d/e/d/a &&
>
> mkdir -p dir2/a/b/c/ &&
> - >dir2/a/b/c/d
> + >dir2/a/b/c/d &&
> +
> + >file
> '
>
> -test_expect_success 'dir-iterator should iterate through all files' '
> - cat >expect-sorted-output <<-\EOF &&
> - [d] (a) [a] ./dir/a
> - [d] (a/b) [b] ./dir/a/b
> - [d] (a/b/c) [c] ./dir/a/b/c
> - [d] (d) [d] ./dir/d
> - [d] (d/e) [e] ./dir/d/e
> - [d] (d/e/d) [d] ./dir/d/e/d
> - [f] (a/b/c/d) [d] ./dir/a/b/c/d
> - [f] (a/e) [e] ./dir/a/e
> - [f] (b) [b] ./dir/b
> - [f] (c) [c] ./dir/c
> - [f] (d/e/d/a) [a] ./dir/d/e/d/a
> - EOF
> +cat >expect-sorted-output <<-\EOF &&
> +[d] (a) [a] ./dir/a
> +[d] (a/b) [b] ./dir/a/b
> +[d] (a/b/c) [c] ./dir/a/b/c
> +[d] (d) [d] ./dir/d
> +[d] (d/e) [e] ./dir/d/e
> +[d] (d/e/d) [d] ./dir/d/e/d
> +[f] (a/b/c/d) [d] ./dir/a/b/c/d
> +[f] (a/e) [e] ./dir/a/e
> +[f] (b) [b] ./dir/b
> +[f] (c) [c] ./dir/c
> +[f] (d/e/d/a) [a] ./dir/d/e/d/a
> +EOF
>
> - test-dir-iterator ./dir >out &&
There is something fishy going on around here in this patch, pushing
the code to prepare test vector out of test_expect_success block. A
mistake in rebasing or something?
If you need to reroll the series to update this part, please rename
the test to t0066 and do remember to update the logmessage of a few
commits that refer to t0065.
Thanks.
next prev parent reply other threads:[~2017-04-20 3:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 13:14 [PATCH v10 0/5] [GSoC] remove_subtree(): reimplement using iterators Daniel Ferreira
2017-04-19 13:14 ` [PATCH v10 1/5] dir_iterator: add tests for dir_iterator API Daniel Ferreira
2017-04-19 13:14 ` [PATCH v10 2/5] remove_subtree(): test removing nested directories Daniel Ferreira
2017-04-19 13:14 ` [PATCH v10 3/5] dir_iterator: refactor dir_iterator_advance Daniel Ferreira
2017-04-19 13:14 ` [PATCH v10 4/5] dir_iterator: rewrite state machine model Daniel Ferreira
2017-04-20 3:30 ` Junio C Hamano [this message]
2017-04-20 9:36 ` Michael Haggerty
2017-04-19 13:14 ` [PATCH v10 5/5] remove_subtree(): reimplement using iterators Daniel Ferreira
2017-04-20 3:23 ` [PATCH v10 0/5] [GSoC] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfuh3ah71.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bnmvco@gmail.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).