From: Junio C Hamano <gitster@pobox.com>
To: Ben Peart <peartben@gmail.com>
Cc: git@vger.kernel.org, benpeart@microsoft.com,
christian.couder@gmail.com, larsxschneider@gmail.com,
peff@peff.net
Subject: Re: [PATCH v7 00/10] refactor the filter process code into a reusable module
Date: Mon, 08 May 2017 10:58:46 +0900 [thread overview]
Message-ID: <xmqqfuggaz3d.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170505152802.6724-1-benpeart@microsoft.com> (Ben Peart's message of "Fri, 5 May 2017 11:27:52 -0400")
Ben Peart <peartben@gmail.com> writes:
> Changes from V6 include:
>
> convert: remove erroneous tests for errno == EPIPE
> - split into separate patch to fix a preexisting bug discovered in the review process
Thanks.
> pkt-line: Update packet_read_line() to test for len > 0
> - split into separate patch to deal with errors that return negative lengths
>
> pkt-line: add packet_read_line_gently()
> - update documentation to clarify return values
> - update white space in function definition
>
I also see some style fixes applied to a few patches. Thanks for
paying attention to details.
Will queue; during the pre-release freeze, new things would move
slowly, but let's see if we have more comments from others and then
merge it to 'next' soon after the 2.13 final.
Thanks.
next prev parent reply other threads:[~2017-05-08 1:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 15:27 [PATCH v7 00/10] refactor the filter process code into a reusable module Ben Peart
2017-05-05 15:27 ` [PATCH v7 01/10] convert: remove erroneous tests for errno == EPIPE Ben Peart
2017-05-05 15:27 ` [PATCH v7 02/10] pkt-line: fix packet_read_line() to handle len < 0 errors Ben Peart
2017-05-05 15:27 ` [PATCH v7 03/10] pkt-line: add packet_read_line_gently() Ben Peart
2017-05-05 15:27 ` [PATCH v7 04/10] convert: move packet_write_line() into pkt-line as packet_writel() Ben Peart
2017-05-13 9:04 ` Jeff King
2017-05-15 4:02 ` Junio C Hamano
2017-05-05 15:27 ` [PATCH v7 05/10] convert: split start_multi_file_filter() into two separate functions Ben Peart
2017-05-05 15:27 ` [PATCH v7 06/10] convert: Separate generic structures and variables from the filter specific ones Ben Peart
2017-05-05 15:27 ` [PATCH v7 07/10] convert: Update generic functions to only use generic data structures Ben Peart
2017-05-05 15:28 ` [PATCH v7 08/10] convert: rename reusable sub-process functions Ben Peart
2017-05-05 15:28 ` [PATCH v7 09/10] sub-process: move sub-process functions into separate files Ben Peart
2017-05-13 9:07 ` Jeff King
2017-05-05 15:28 ` [PATCH v7 10/10] convert: Update subprocess_read_status to not die on EOF Ben Peart
2017-05-08 1:58 ` Junio C Hamano [this message]
2017-05-13 9:16 ` [PATCH v7 00/10] refactor the filter process code into a reusable module Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfuggaz3d.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=benpeart@microsoft.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=peartben@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).