git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Emily Xie <emilyxxie@gmail.com>
Cc: git@vger.kernel.org, novalis@novalis.org
Subject: Re: [PATCH] pathspec: die on empty strings as pathspec
Date: Sat, 10 Jun 2017 14:54:38 +0900	[thread overview]
Message-ID: <xmqqfuf82xr5.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170607033308.33550-1-emilyxxie@gmail.com> (Emily Xie's message of "Tue, 6 Jun 2017 23:33:08 -0400")

Emily Xie <emilyxxie@gmail.com> writes:

> diff --git a/t/t3700-add.sh b/t/t3700-add.sh
> index f3a4b4a..40a0d2b 100755
> --- a/t/t3700-add.sh
> +++ b/t/t3700-add.sh
> @@ -331,9 +331,8 @@ test_expect_success 'git add --dry-run --ignore-missing of non-existing file out
>  	test_i18ncmp expect.err actual.err
>  '
>  
> -test_expect_success 'git add empty string should invoke warning' '
> -	git add "" 2>output &&
> -	test_i18ngrep "warning: empty strings" output
> +test_expect_success 'git add empty string should fail' '
> +	test_must_fail git add ""
>  '

Doesn't this affect the tests that follow this step?  We used to
warn but went ahead and added all of them anyway, but now we fail
without adding anything, which means that the state of the index
before and after this patch would be different.

>  test_expect_success 'git add --chmod=[+-]x stages correctly' '

  parent reply	other threads:[~2017-06-10  5:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07  3:33 [PATCH] pathspec: die on empty strings as pathspec Emily Xie
2017-06-09 16:28 ` Junio C Hamano
2017-06-10  6:21   ` Jeff King
2017-06-10 11:03     ` Junio C Hamano
2017-06-09 16:50 ` Brandon Williams
2017-06-10  5:54 ` Junio C Hamano [this message]
2017-06-23  2:34   ` Emily Xie
2017-06-23  4:09     ` Junio C Hamano
2017-06-23  4:46       ` Junio C Hamano
2017-06-23 18:04         ` Junio C Hamano
2017-06-23 20:52           ` Torsten Bögershausen
2017-06-23 20:59             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfuf82xr5.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=emilyxxie@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=novalis@novalis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).