git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Michael Haggerty" <mhagger@alum.mit.edu>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Stefan Beller" <sbeller@google.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"David Turner" <novalis@novalis.org>,
	"Brandon Williams" <bmwill@google.com>,
	"Johannes Sixt" <j6t@kdbg.org>, "Øyvind Holm" <sunny@sunbase.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/2] for_each_bisect_ref(): don't trim refnames
Date: Wed, 14 Jun 2017 03:05:17 -0700	[thread overview]
Message-ID: <xmqqfuf251gi.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170614093242.twipnjncaka2lhyg@sigill.intra.peff.net> (Jeff King's message of "Wed, 14 Jun 2017 05:32:42 -0400")

Jeff King <peff@peff.net> writes:

>> Since we obviously don't have even a single test for "--bisect", that
>> might be worth adding.
>
> It turns out we do, but none that actually check that we use the default
> refnames. So maybe squash this in?

Sounds sensible.  Thanks.

>
> diff --git a/t/t6002-rev-list-bisect.sh b/t/t6002-rev-list-bisect.sh
> index 3bf2759ea..534903bbd 100755
> --- a/t/t6002-rev-list-bisect.sh
> +++ b/t/t6002-rev-list-bisect.sh
> @@ -235,4 +235,18 @@ test_sequence "--bisect"
>  
>  #
>  #
> +
> +test_expect_success '--bisect can default to good/bad refs' '
> +	git update-ref refs/bisect/bad c3 &&
> +	good=$(git rev-parse b1) &&
> +	git update-ref refs/bisect/good-$good $good &&
> +	good=$(git rev-parse c1) &&
> +	git update-ref refs/bisect/good-$good $good &&
> +
> +	# the only thing between c3 and c1 is c2
> +	git rev-parse c2 >expect &&
> +	git rev-list --bisect >actual &&
> +	test_cmp expect actual
> +'
> +
>  test_done

  reply	other threads:[~2017-06-14 10:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14  0:06 [BUG] b9c8e7f2fb6e breaks git bisect visualize Øyvind A. Holm
2017-06-14  8:36 ` Michael Haggerty
2017-06-14  9:07   ` [PATCH 0/2] Fix a refname trimming problem in `log --bisect` Michael Haggerty
2017-06-14  9:07     ` [PATCH 1/2] for_each_bisect_ref(): don't trim refnames Michael Haggerty
2017-06-14  9:22       ` Jeff King
2017-06-14  9:32         ` Jeff King
2017-06-14 10:05           ` Junio C Hamano [this message]
2017-06-15 22:26       ` Junio C Hamano
2017-06-14  9:07     ` [PATCH 2/2] prefix_ref_iterator_advance(): relax the check of trim length Michael Haggerty
2017-06-14  9:24     ` [PATCH 0/2] Fix a refname trimming problem in `log --bisect` Jeff King
2017-06-14 10:09     ` Junio C Hamano
2017-06-14  9:18   ` [BUG] b9c8e7f2fb6e breaks git bisect visualize Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfuf251gi.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=bmwill@google.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=mhagger@alum.mit.edu \
    --cc=novalis@novalis.org \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    --cc=sunny@sunbase.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).