From: Junio C Hamano <gitster@pobox.com>
To: "Takashi Iwai" <tiwai@suse.de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Andreas Stieger <astieger@suse.com>
Subject: Re: [PATCH] hash: Allow building with the external sha1dc library
Date: Fri, 11 Aug 2017 17:42:25 -0700 [thread overview]
Message-ID: <xmqqfucxy5u6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACBZZX7M=H8tNkZXpHBvv0rbY58EJk4dkoUzGKMftWoKUqF8sA@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 28 Jul 2017 18:04:18 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Fri, Jul 28, 2017 at 5:58 PM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>
> I sent this last bit a tad too soon in a checkout of sha1collisiondetection.git:
>
> $ make PREFIX=/tmp/local install >/dev/null 2>&1 && find /tmp/local/ -type f
> /tmp/local/include/sha1dc/sha1.h
> /tmp/local/bin/sha1dcsum
> /tmp/local/bin/sha1dcsum_partialcoll
> /tmp/local/lib/libsha1detectcoll.a
> /tmp/local/lib/libsha1detectcoll.so.1.0.0
> /tmp/local/lib/libsha1detectcoll.la
>
> So the upstream library expects you (and it's documented in their README) to do:
>
> #include <sha1dc/sha1.h>
>
> But your patch is just doing:
>
> #include <sha1.h>
>
> At best this seems like a trivial bug and at worst us encoding some
> Suse-specific packaging convention in git, since other distros would
> presumably want to package this in /usr/include/sha1dc/sha1.h as
> upstream suggests. I.e. using the ambiguous sha1.h name is not
> something upstream's doing by default, it's something you're doing in
> your package.
I do not think I saw any updates to this thread. Should I consider
the topic ti/external-sha1dc now abandoned?
As we have finished Git 2.14 cycle, in preparation for the next one,
the 'next' branch will be rewound and rebuilt early next week. I do
not mind tentatively ejecting some topics that needs fix-ups out of
'next' to give them a clean restart. If there will be a reroll that
addresses the concerns raised during the discussion, please let me
know.
Thanks.
next prev parent reply other threads:[~2017-08-12 0:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 5:57 [PATCH] hash: Allow building with the external sha1dc library Takashi Iwai
2017-07-25 19:06 ` Junio C Hamano
2017-07-28 15:58 ` Ævar Arnfjörð Bjarmason
2017-07-28 16:04 ` Ævar Arnfjörð Bjarmason
2017-07-31 22:28 ` Junio C Hamano
2017-08-01 5:52 ` Takashi Iwai
2017-08-12 0:42 ` Junio C Hamano [this message]
2017-08-12 6:50 ` Takashi Iwai
2017-08-01 5:46 ` Takashi Iwai
2017-08-01 15:56 ` Junio C Hamano
2017-08-01 16:12 ` Takashi Iwai
2017-08-01 19:55 ` Ævar Arnfjörð Bjarmason
2017-08-01 20:50 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfucxy5u6.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=astieger@suse.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).