From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH 5/3] refs: pass NULL to resolve_refdup() if hash is not needed
Date: Sun, 01 Oct 2017 17:29:10 +0900 [thread overview]
Message-ID: <xmqqfub3uv8p.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <c18156ec-4c59-eb96-3177-0b1085b0a5c1@web.de> ("René Scharfe"'s message of "Sun, 1 Oct 2017 09:29:03 +0200")
René Scharfe <l.s.r@web.de> writes:
> This allows us to get rid of several write-only variables.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> builtin/checkout.c | 3 +--
> builtin/receive-pack.c | 3 +--
> ref-filter.c | 7 ++-----
> reflog-walk.c | 6 ++----
> transport.c | 3 +--
> wt-status.c | 4 +---
> 6 files changed, 8 insertions(+), 18 deletions(-)
Both patches looked good to me.
It's a bit surprising that we care so much about where a symbolic
ref points at, but it is understandable from the list of files
affected.
prev parent reply other threads:[~2017-10-01 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-23 9:41 [PATCH 1/3] refs: make sha1 output parameter of refs_resolve_ref_unsafe() optional René Scharfe
2017-09-23 9:44 ` [PATCH 2/3] refs: pass NULL to refs_resolve_ref_unsafe() if hash is not needed René Scharfe
2017-09-23 9:45 ` [PATCH 3/3] refs: pass NULL to resolve_ref_unsafe() " René Scharfe
2017-09-24 1:26 ` [PATCH 1/3] refs: make sha1 output parameter of refs_resolve_ref_unsafe() optional Junio C Hamano
2017-09-24 12:39 ` René Scharfe
2017-10-01 7:28 ` [PATCH 4/3] refs: pass NULL to refs_resolve_refdup() if hash is not needed René Scharfe
2017-10-01 7:29 ` [PATCH 5/3] refs: pass NULL to resolve_refdup() " René Scharfe
2017-10-01 8:29 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfub3uv8p.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).