From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index
Date: Mon, 22 Jan 2018 15:09:54 -0800 [thread overview]
Message-ID: <xmqqfu6xjxrx.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20180122110334.4411-4-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Mon, 22 Jan 2018 18:03:34 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh
> index af9b847761..d2a8e0312a 100755
> --- a/t/t1700-split-index.sh
> +++ b/t/t1700-split-index.sh
> @@ -401,4 +401,23 @@ done <<\EOF
> 0642 -rw-r---w-
> EOF
>
> +test_expect_success SANITY 'graceful handling when splitting index is not allowed' '
Is SANITY the only prereq we want, or do we want both it and POSIXPERM?
In "git grep SANITY t/" output, we see that they are almost always
used together.
> + test_create_repo ro &&
> + (
> + cd ro &&
> + test_commit initial &&
> + git update-index --split-index &&
> + test -f .git/sharedindex.*
> + ) &&
> + cp ro/.git/index new-index &&
> + test_when_finished "chmod u+w ro/.git" &&
> + chmod u-w ro/.git &&
> + GIT_INDEX_FILE="$(pwd)/new-index" git -C ro update-index --split-index &&
> + chmod u+w ro/.git &&
> + rm ro/.git/sharedindex.* &&
> + GIT_INDEX_FILE=new-index git ls-files >actual &&
> + echo initial.t >expected &&
> + test_cmp expected actual
> +'
> +
> test_done
next prev parent reply other threads:[~2018-01-22 23:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 11:03 [PATCH 0/3] nd/shared-index-fix update Nguyễn Thái Ngọc Duy
2018-01-22 11:03 ` [PATCH 1/3] read-cache.c: change type of "temp" in write_shared_index() Nguyễn Thái Ngọc Duy
2018-01-22 11:03 ` [PATCH 2/3] read-cache.c: move tempfile creation/cleanup out of write_shared_index Nguyễn Thái Ngọc Duy
2018-01-22 11:03 ` [PATCH 3/3] read-cache: don't write index twice if we can't write shared index Nguyễn Thái Ngọc Duy
2018-01-22 23:09 ` Junio C Hamano [this message]
2018-01-23 4:06 ` Duy Nguyen
2018-01-24 9:38 ` [PATCH 0/3] nd/shared-index-fix updates Nguyễn Thái Ngọc Duy
2018-01-24 9:38 ` [PATCH 1/3] read-cache.c: change type of "temp" in write_shared_index() Nguyễn Thái Ngọc Duy
2018-01-24 9:38 ` [PATCH 2/3] read-cache.c: move tempfile creation/cleanup out of write_shared_index Nguyễn Thái Ngọc Duy
2018-01-24 9:38 ` [PATCH 3/3] read-cache: don't write index twice if we can't write shared index Nguyễn Thái Ngọc Duy
2018-01-24 18:09 ` [PATCH 0/3] nd/shared-index-fix updates Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2018-01-14 9:36 [PATCH v3 4/3] read-cache: don't try to write index if we can't write shared index Duy Nguyen
2018-01-14 10:18 ` [PATCH 1/3] read-cache.c: change type of "temp" in write_shared_index() Nguyễn Thái Ngọc Duy
2018-01-14 10:18 ` [PATCH 3/3] read-cache: don't write index twice if we can't write shared index Nguyễn Thái Ngọc Duy
2018-01-18 11:36 ` SZEDER Gábor
2018-01-18 12:47 ` Duy Nguyen
2018-01-18 13:29 ` Jeff King
2018-01-18 13:36 ` Duy Nguyen
2018-01-18 15:00 ` Duy Nguyen
2018-01-18 21:37 ` Jeff King
2018-01-18 22:32 ` SZEDER Gábor
2018-01-19 0:30 ` Duy Nguyen
2018-01-22 18:27 ` SZEDER Gábor
2018-01-22 19:46 ` Eric Sunshine
2018-01-22 22:10 ` SZEDER Gábor
2018-01-24 9:11 ` Duy Nguyen
2018-01-26 22:44 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfu6xjxrx.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).