git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
* [PATCH] t1510-repo-setup.sh: rm useless mkdir
@ 2018-04-15  2:45 qingyunha
  2018-04-16  1:18 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: qingyunha @ 2018-04-15  2:45 UTC (permalink / raw)
  To: git; +Cc: Tao Qingyun

From: Tao Qingyun <845767657@qq.com>

Signed-off-by: Tao Qingyun <845767657@qq.com>
---
 t/t1510-repo-setup.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/t/t1510-repo-setup.sh b/t/t1510-repo-setup.sh
index e6854b828..972bd9c78 100755
--- a/t/t1510-repo-setup.sh
+++ b/t/t1510-repo-setup.sh
@@ -238,7 +238,6 @@ test_expect_success '#0: nonbare repo, no explicit configuration' '
 '
 
 test_expect_success '#1: GIT_WORK_TREE without explicit GIT_DIR is accepted' '
-	mkdir -p wt &&
 	try_repo 1 "$here" unset unset "" unset \
 		"$here/1/.git" "$here" "$here" 1/ \
 		"$here/1/.git" "$here" "$here" 1/sub/ 2>message &&
-- 
2.16.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] t1510-repo-setup.sh: rm useless mkdir
  2018-04-15  2:45 [PATCH] t1510-repo-setup.sh: rm useless mkdir qingyunha
@ 2018-04-16  1:18 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2018-04-16  1:18 UTC (permalink / raw)
  To: qingyunha; +Cc: git, Tao Qingyun, Jonathan Nieder

qingyunha@foxmail.com writes:

> From: Tao Qingyun <845767657@qq.com>
>
> Signed-off-by: Tao Qingyun <845767657@qq.com>
> ---
>  t/t1510-repo-setup.sh | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/t/t1510-repo-setup.sh b/t/t1510-repo-setup.sh
> index e6854b828..972bd9c78 100755
> --- a/t/t1510-repo-setup.sh
> +++ b/t/t1510-repo-setup.sh
> @@ -238,7 +238,6 @@ test_expect_success '#0: nonbare repo, no explicit configuration' '
>  '
>  
>  test_expect_success '#1: GIT_WORK_TREE without explicit GIT_DIR is accepted' '
> -	mkdir -p wt &&
>  	try_repo 1 "$here" unset unset "" unset \
>  		"$here/1/.git" "$here" "$here" 1/ \
>  		"$here/1/.git" "$here" "$here" 1/sub/ 2>message &&

Interesting.  

This was added by 4868b2ea ("setup: officially support --work-tree
without --git-dir", 2011-01-19), together with others like 9/wt that
do get used.  I am not sure if the old codebase needed this directory
created and over time we lost the need for it, or what.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-15  2:45 [PATCH] t1510-repo-setup.sh: rm useless mkdir qingyunha
2018-04-16  1:18 ` Junio C Hamano

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox