From: Junio C Hamano <gitster@pobox.com>
To: qingyunha@foxmail.com
Cc: git@vger.kernel.org, Tao Qingyun <845767657@qq.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH] t1510-repo-setup.sh: rm useless mkdir
Date: Mon, 16 Apr 2018 10:18:39 +0900 [thread overview]
Message-ID: <xmqqfu3wymmo.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180415024504.2397-1-qingyunha@foxmail.com> (qingyunha@foxmail.com's message of "Sun, 15 Apr 2018 10:45:04 +0800")
qingyunha@foxmail.com writes:
> From: Tao Qingyun <845767657@qq.com>
>
> Signed-off-by: Tao Qingyun <845767657@qq.com>
> ---
> t/t1510-repo-setup.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/t/t1510-repo-setup.sh b/t/t1510-repo-setup.sh
> index e6854b828..972bd9c78 100755
> --- a/t/t1510-repo-setup.sh
> +++ b/t/t1510-repo-setup.sh
> @@ -238,7 +238,6 @@ test_expect_success '#0: nonbare repo, no explicit configuration' '
> '
>
> test_expect_success '#1: GIT_WORK_TREE without explicit GIT_DIR is accepted' '
> - mkdir -p wt &&
> try_repo 1 "$here" unset unset "" unset \
> "$here/1/.git" "$here" "$here" 1/ \
> "$here/1/.git" "$here" "$here" 1/sub/ 2>message &&
Interesting.
This was added by 4868b2ea ("setup: officially support --work-tree
without --git-dir", 2011-01-19), together with others like 9/wt that
do get used. I am not sure if the old codebase needed this directory
created and over time we lost the need for it, or what.
prev parent reply other threads:[~2018-04-16 1:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-15 2:45 [PATCH] t1510-repo-setup.sh: rm useless mkdir qingyunha
2018-04-16 1:18 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfu3wymmo.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=845767657@qq.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=qingyunha@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).