From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, avarab@gmail.com
Subject: Re: [PATCH 2/2] builtin/blame: highlight recently changed lines
Date: Tue, 17 Apr 2018 12:23:20 +0900 [thread overview]
Message-ID: <xmqqfu3uv7mf.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180416220955.46163-3-sbeller@google.com> (Stefan Beller's message of "Mon, 16 Apr 2018 15:09:55 -0700")
Stefan Beller <sbeller@google.com> writes:
> Choose a different color for dates and imitate a 'temperature cool down'
> depending upon age.
>
> Originally I had planned to have the temperature cooldown dependent on
> the age of the project or file for example, as that might scale better,
> but that can be added on top of this commit, e.g. instead of giving a
> date, you could imagine giving a percentage that would be the linearly
> interpolated between now and the beginning of the file.
> ...
> @@ -323,6 +324,7 @@ static const char *format_time(timestamp_t time, const char *tz_str,
> #define OUTPUT_SHOW_EMAIL 0400
> #define OUTPUT_LINE_PORCELAIN 01000
> #define OUTPUT_COLOR_LINE 02000
> +#define OUTPUT_HEATED_LINES 04000
How about calling it OUTPUT_SHOW_AGE_WITH_COLOR or something like
that instead? Anything with "AGE" in it, if that is what you are
trying to indicate, would be more appropriate than "HEATED", which
does not convey much meaning to readers unless you explain what
determines the temperature in your mind.
next prev parent reply other threads:[~2018-04-17 3:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 22:09 [PATCH 0/2] blame: color line by commit Stefan Beller
2018-04-16 22:09 ` [PATCH 1/2] builtin/blame: dim uninteresting metadata lines Stefan Beller
2018-04-17 3:17 ` Junio C Hamano
2018-04-17 19:04 ` Stefan Beller
2018-04-16 22:09 ` [PATCH 2/2] builtin/blame: highlight recently changed lines Stefan Beller
2018-04-17 3:23 ` Junio C Hamano [this message]
2018-04-17 3:29 ` Junio C Hamano
2018-04-17 19:31 ` Stefan Beller
2018-04-17 19:35 ` Stefan Beller
2018-04-17 21:30 ` [PATCH 1/2] builtin/blame: dim uninteresting metadata lines Stefan Beller
2018-04-17 21:30 ` [PATCH 2/2] builtin/blame: highlight recently changed lines Stefan Beller
2018-04-17 21:54 ` Eric Sunshine
2018-04-18 0:39 ` Junio C Hamano
2018-06-09 11:26 ` René Scharfe
2018-06-11 23:56 ` Stefan Beller
2018-06-14 17:37 ` Junio C Hamano
2018-04-18 0:34 ` [PATCH 1/2] builtin/blame: dim uninteresting metadata lines Junio C Hamano
2018-04-18 0:12 ` [PATCH 2/2] builtin/blame: highlight recently changed lines Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfu3uv7mf.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).