From: Junio C Hamano <gitster@pobox.com>
To: Sebastian Kisela <skisela@redhat.com>
Cc: git@vger.kernel.org, Todd Zullinger <tmz@pobox.com>
Subject: Re: [PATCH 1/2] git-instaweb: support Fedora/Red Hat apache module path
Date: Tue, 07 Aug 2018 15:11:48 -0700 [thread overview]
Message-ID: <xmqqftzpkesb.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <xmqqk1p1kgwq.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Tue, 07 Aug 2018 14:25:57 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> if test -z "$module_path"
> then
> for candidate in \
> /etc/httpd \
> /usr/lib/apache2 \
> /usr/lib/httpd \
I obviously missed semicolon here...
> do
> if test -d "$candidate/modules"
> then
> module_path="$candidate/modules"
> break
> fi
One more thing to note is that the fourth candidate might not end
with "/modules" and force us to update these existing three to have
"/modules" at the end and lose appending "/modules" from these two
lines to compensate. That is sort of deliberate (i.e. as long as we
can share "/modules" as a common substring at the end, it is OK to
take advantage of that).
> done
> fi
>
> is when you go from 2 to 3. Two points to note are:
>
> - It would be easier to add the fourth one this way
>
> - The explicit "break" makes it clear that the paths are listed in
> decreasing order of precedence (i.e. /etc/httpd if exists makes
> /usr/lib/httpd ignored even if the latter exists); the original
> "test -d X && M=X ; test -d Y && M=Y" gives higher precedence to
> the later items but readers need to wonder if it is intended or
> the code is simply being sloppy.
>
> Hope this helps.
next prev parent reply other threads:[~2018-08-07 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 7:25 [PATCH 1/2] git-instaweb: support Fedora/Red Hat apache module path Sebastian Kisela
2018-08-07 7:25 ` [PATCH 2/2] git-instaweb: fix apache2 config with apache >= 2.4 Sebastian Kisela
2018-08-07 21:25 ` [PATCH 1/2] git-instaweb: support Fedora/Red Hat apache module path Junio C Hamano
2018-08-07 22:11 ` Junio C Hamano [this message]
2018-08-08 8:49 ` Sebastian Kisela
2018-08-08 8:49 ` Sebastian Kisela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqftzpkesb.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=skisela@redhat.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).