git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Shulhan <m.shulhan@gmail.com>
Cc: git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Brandon Williams <bmwill@google.com>
Subject: Re: [RFC PATCH 0/1] builtin/remote: quote remote name on error to display empty name
Date: Wed, 12 Sep 2018 09:20:07 -0700	[thread overview]
Message-ID: <xmqqftyen0w8.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180912144504.7498-1-m.shulhan@gmail.com> (Shulhan's message of "Wed, 12 Sep 2018 21:45:03 +0700")

Shulhan <m.shulhan@gmail.com> writes:

> Rationale: consistent error format
>
> When adding new remote name with empty string, git will print the
> following error message,
>
>   fatal: '' is not a valid remote name\n
>
> But when removing remote name with empty string as input, git did not
> print the empty string with quote,
>
>   fatal: No such remote: \n

Thanks for noticing.  I think the consistency given by the patch 1/1
is good.

> Follow up question: If this is ok, should the po files also updated?

They should be updated, but not by you and not as part of this
change.  The po files will be updated by our l10n coordinator,
typically when it gets close to the release time, for all the
message changes done during the release cycle.

Thanks.


      parent reply	other threads:[~2018-09-12 16:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12 14:45 [RFC PATCH 0/1] builtin/remote: quote remote name on error to display empty name Shulhan
2018-09-12 14:45 ` [RFC PATCH 1/1] " Shulhan
2018-09-12 21:28   ` Junio C Hamano
2018-09-12 16:20 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqftyen0w8.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bmwill@google.com \
    --cc=git@vger.kernel.org \
    --cc=m.shulhan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).