git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Daniels Umanovskis <daniels@umanovskis.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] doc: move git-rev-parse from porcelain to plumbing
Date: Thu, 11 Oct 2018 08:40:42 +0900	[thread overview]
Message-ID: <xmqqftxdjrph.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <7c08fd68-9a0a-ab2a-0667-f51726fa691b@umanovskis.se> (Daniels Umanovskis's message of "Thu, 11 Oct 2018 00:56:08 +0200")

Daniels Umanovskis <daniels@umanovskis.se> writes:

> On 10/11/18 12:26 AM, Junio C Hamano wrote:
>> Among the remaining ones in the list, cherry and get-tar-commit-id
>> are probably better classified as plumbing.  I do not know why
>> cherry is marked for completion; perhaps some crazy people use that
>> on the command line?
>
> I think cherry could go either way, get-tar-commit-id is definitely
> plumbing. Would you like me to fix those two on the same patch then?

No, what you sent for rev-parse is already good.  A separate patch
that addresses other ones can be discussed as an orthogonal matter.
It even may deserve to make them two separate patches, as I
anticipate that some people would resist marking "cherry" as
plumbing, so that only one can be applied while dropping the other
as/if needed.

Thanks.


      reply	other threads:[~2018-10-10 23:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 21:37 [PATCH] doc: move git-rev-parse from porcelain to plumbing Daniels Umanovskis
2018-10-10 22:26 ` Junio C Hamano
2018-10-10 22:56   ` Daniels Umanovskis
2018-10-10 23:40     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqftxdjrph.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=daniels@umanovskis.se \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).