From: Junio C Hamano <gitster@pobox.com> To: "Randall S. Becker" <rsbecker@nexbridge.com> Cc: <git@vger.kernel.org>, Johannes Schindelin <johannes.schindelin@gmx.de>, Duy Nguyen <pclouds@gmail.com> Subject: Re: [ANNOUNCE] Git v2.21.0-rc2 Date: Wed, 20 Feb 2019 11:41:55 -0800 Message-ID: <xmqqftsiw8l8.fsf@gitster-ct.c.googlers.com> (raw) In-Reply-To: <012601d4c8b5$54f1b730$fed52590$@nexbridge.com> (Randall S. Becker's message of "Tue, 19 Feb 2019 19:43:37 -0500") "Randall S. Becker" <rsbecker@nexbridge.com> writes: > On February 19, 2019 18:29, Junio C Hamano wrote: >> A release candidate Git v2.21.0-rc2 is now available for testing at the usual >> places. It is comprised of 474 non-merge commits since v2.20.0, contributed >> by 61 people, 16 of which are new faces. > > Thanks. t5562 works properly on NonStop (3 tests under various > loads). I am starting a full regression test now - see you in two > days or so with a full report. Thanks. In the end I ended up doing the following: - kept most of your "feed NULs generated from a helper program via pipe, instead of reading from /dev/zero" patch, - replaced the helper program used in the above with the test-tool one by Dscho, - used Max's "do not reuse the output file---the background writer about to die may still have it open when the next test starts", - used Max's "when testing the program with overly large input declared with content-length, do not have to feed from /dev/zero; /dev/null suffices as a mistaken program attempting to read would die when seeing EOF anyway" patch to reduce one mention of /dev/zero (or one pipe from the helper output) further. Hopefully Dscho's Azure thing would also be happy with one less use of Perl script. As I said earlier, a few places in t/ still mention /dev/zero and I think it is a real bug on platforms without /dev/zero in t4153: $ git grep -h dev/zero t/ test_must_fail test_terminal git am --3way </dev/zero && test_must_fail test_terminal git am --reject </dev/zero && Curiously, applying the attached patch and running the test on Linux would notice that we do not have such a device file, and the use of test_must_fail does *not* make it a-OK [*]. I am not sure why you are not getting hit by the same issue. Side note: test_must_fail is to ensure that the command exits in a controlled way without segfault, so at the first glance, replacing /dev/zero with something nonsensical and nonexistent ought to make the command pass, but that is not the case. The shell notices redirection failure and aborts the &&-chain. This behaviour matches what we want, so I won't complain ;-) Another mention of /dev/zero appears in t/helper/test-sha1.sh (not to be confused with t/helper/test-sha1.c). This seems to be run only with an explicit "make -C t/helper check-sha1" request, so perhaps nobody on your platform ran it to get hit by it. I wonder if anybody runs this on any platform, to be honest, though. Duy Cc'ed as the last person to touch that particular target---yes, I know I was guilty of introducing it in b65bc21e ("Makefile: add framework to verify and bench sha1 implementations.", 2006-06-24). t/t4153-am-resume-override-opts.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t4153-am-resume-override-opts.sh b/t/t4153-am-resume-override-opts.sh index 8ea22d1bcb..29ef22c94f 100755 --- a/t/t4153-am-resume-override-opts.sh +++ b/t/t4153-am-resume-override-opts.sh @@ -40,7 +40,7 @@ test_expect_success TTY '--3way overrides --no-3way' ' # Applying side1 with am --3way will succeed due to the threeway-merge. # Applying side2 will fail as --3way does not apply to it. - test_must_fail test_terminal git am --3way </dev/zero && + test_must_fail test_terminal git am --3way </dev/zarro && test_path_is_dir .git/rebase-apply && test side1 = "$(cat file2)" ' @@ -94,7 +94,7 @@ test_expect_success TTY '--reject overrides --no-reject' ' test_path_is_dir .git/rebase-apply && test_path_is_missing file.rej && - test_must_fail test_terminal git am --reject </dev/zero && + test_must_fail test_terminal git am --reject </dev/zarro && test_path_is_dir .git/rebase-apply && test_path_is_file file.rej '
next prev parent reply other threads:[~2019-02-20 19:42 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-19 23:29 Junio C Hamano 2019-02-20 0:43 ` Randall S. Becker 2019-02-20 19:41 ` Junio C Hamano [this message] 2019-02-20 20:46 ` Johannes Schindelin 2019-02-21 13:10 ` Duy Nguyen 2019-02-21 23:55 ` brian m. carlson 2019-02-22 9:13 ` Duy Nguyen 2019-02-21 15:54 ` Randall S. Becker 2019-02-21 20:04 ` Junio C Hamano 2019-02-21 21:06 ` SZEDER Gábor 2019-02-21 21:30 ` Randall S. Becker 2019-02-21 19:59 ` Randall S. Becker 2019-02-21 10:46 ` Git for Windows v2.21.0-rc2, was " Johannes Schindelin 2019-02-21 19:28 ` [PATCH 0/2] BSD portability fixes for 2.21.0-rc2 Ævar Arnfjörð Bjarmason 2019-02-22 0:37 ` Josh Steadmon 2019-02-21 19:28 ` [PATCH 1/2] tests: fix unportable "\?" and "\+" regex syntax Ævar Arnfjörð Bjarmason 2019-02-22 5:00 ` Junio C Hamano 2019-02-21 19:28 ` [PATCH 2/2] commit-graph tests: fix cryptic unportable "dd" invocation Ævar Arnfjörð Bjarmason 2019-02-21 20:43 ` SZEDER Gábor 2019-02-21 22:26 ` Ævar Arnfjörð Bjarmason 2019-02-22 10:50 ` SZEDER Gábor 2019-02-22 14:34 ` Ævar Arnfjörð Bjarmason 2019-02-22 18:30 ` Junio C Hamano 2019-02-22 18:35 ` Todd Zullinger 2019-02-22 19:23 ` [PATCH v3] commit-graph tests: fix " Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=xmqqftsiw8l8.fsf@gitster-ct.c.googlers.com \ --to=gitster@pobox.com \ --cc=git@vger.kernel.org \ --cc=johannes.schindelin@gmx.de \ --cc=pclouds@gmail.com \ --cc=rsbecker@nexbridge.com \ --subject='Re: [ANNOUNCE] Git v2.21.0-rc2' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git