From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: "Christian Couder" <christian.couder@gmail.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jonathan Tan" <jonathantanmy@google.com>,
"Brandon Williams" <bmwill@google.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH 2/3] t: add t0016-oidmap.sh
Date: Mon, 10 Jun 2019 09:46:27 -0700 [thread overview]
Message-ID: <xmqqftoho0bg.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190609092259.GB24208@szeder.dev> ("SZEDER Gábor"'s message of "Sun, 9 Jun 2019 11:22:59 +0200")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> So, 'test oidmap' from the previous patch prints the value we want to
> check with:
>
> printf("%u\n", sha1hash(oid.hash));
>
> First, since object ids inherently make more sense as hex values, it
> would be more appropriate to print that hash with the '%x' format
> specifier, and then we wouldn't need Perl's hex() anymore, and thus
> could swap the order of the first four bytes in oidmap's hash without
> relying on Perl, e.g. with:
>
> sed -e 's/^\(..\)\(..\)\(..\)\(..\).*/\4\3\2\1/'
>
> Second, and more importantly, the need for swapping the byte order
> indicates that this test would fail on big-endian systems, I'm afraid.
> So I think we need an additional bswap32() on the printing side, and
> then could further simplify 'test_oidhash':
Yup, if we are doing an ad-hoc t/helper/ command, we should strive
to make it help the driving scripts around it to become simpler, and
your suggestion to do s/%u/%x/ is a good example of doing so.
Thanks for a dose of sanity. The goal of the series may be
worthwhile, and helping hands in improving its execution is very
much appreciated.
next prev parent reply other threads:[~2019-06-10 16:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 4:49 [PATCH 0/3] Test oidmap Christian Couder
2019-06-09 4:49 ` [PATCH 1/3] t/helper: add test-oidmap.c Christian Couder
2019-06-09 4:49 ` [PATCH 2/3] t: add t0016-oidmap.sh Christian Couder
2019-06-09 9:22 ` SZEDER Gábor
2019-06-09 20:24 ` Christian Couder
2019-06-09 21:21 ` SZEDER Gábor
2019-06-09 21:51 ` Christian Couder
2019-06-10 16:46 ` Junio C Hamano [this message]
2019-06-13 17:19 ` Jeff King
2019-06-13 17:52 ` SZEDER Gábor
2019-06-13 19:02 ` Jeff King
2019-06-13 22:22 ` Junio C Hamano
2019-06-14 10:36 ` Christian Couder
2019-06-09 4:49 ` [PATCH 3/3] oidmap: use sha1hash() instead of static hash() function Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqftoho0bg.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).