git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t/perf: rename duplicate-numbered test script
Date: Mon, 12 Aug 2019 09:04:36 -0700	[thread overview]
Message-ID: <xmqqftm6bca3.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190812155803.GA25161@sigill.intra.peff.net> (Jeff King's message of "Mon, 12 Aug 2019 11:58:03 -0400")

Jeff King <peff@peff.net> writes:

> There are two perf scripts numbered p5600, but with otherwise different
> names ("clone-reference" versus "partial-clone"). We store timing
> results in files named after the whole script, so internally we don't
> get confused between the two. But "aggregate.perl" just prints the test
> number for each result, giving multiple entries for "5600.3". It also
> makes it impossible to skip one test but not the other with
> GIT_SKIP_TESTS.
>
> Let's renumber the one that appeared later (by date -- the source of the
> problem is that the two were developed on independent branches). For the
> non-perf test suite, our test-lint rule would have complained about this
> when the two were merged, but t/perf never learned that trick.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> This is meant for 2.23, but obviously it's not hurting anything if it
> doesn't make the cut. I double-checked that there is no conflict with
> anything on pu, either. :)

Thanks for being careful.  Will apply.

>  t/perf/{p5600-clone-reference.sh => p5601-clone-reference.sh} | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename t/perf/{p5600-clone-reference.sh => p5601-clone-reference.sh} (100%)
>
> diff --git a/t/perf/p5600-clone-reference.sh b/t/perf/p5601-clone-reference.sh
> similarity index 100%
> rename from t/perf/p5600-clone-reference.sh
> rename to t/perf/p5601-clone-reference.sh

By the way, do we feel differently (e.g. more risky) when we see
100% rename without the "index old-oid..new-oid mode" lines and when
we see 99% rename with one, with a one-line change?

  reply	other threads:[~2019-08-12 16:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 15:58 [PATCH] t/perf: rename duplicate-numbered test script Jeff King
2019-08-12 16:04 ` Junio C Hamano [this message]
2019-08-12 16:13   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqftm6bca3.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).