From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 364271F463 for ; Mon, 2 Dec 2019 06:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727465AbfLBGN0 (ORCPT ); Mon, 2 Dec 2019 01:13:26 -0500 Received: from pb-smtp21.pobox.com ([173.228.157.53]:53252 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727462AbfLBGNZ (ORCPT ); Mon, 2 Dec 2019 01:13:25 -0500 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 8FE9C97978; Mon, 2 Dec 2019 01:13:20 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=Xa2zQxckUL2VKHW4a5ixGZvLcKY=; b=wlk01P 1iZF3pjQN7aF1Z7sqzHn3FjpAf9CrjeHirhkXNgqQ2+0ZwUerXQaNt5n7B7/nmBC jzKrQr04ZgKBZW8ZhW0HEntH68OLP5yB1EO8A4vtMkMKj7K5uADg7YCILXWmCXwd 6PO4qmbx8rdq12vdYNDdRriq2wn77VRTVKFkI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=XYU6195X2CGBqKSD0Psb93D2wfbIoa7P QDv8iQqhEBNl6zMn3Boo4NXRdfBKjBU1p+0S2bxpw+kc5upbzVgY6L3y9Ges++99 YijSKrcuYcb0gtOXkgshjsZgCP7Jn9hCNqIl82Hfk8X8hB+1Mc2Tm34stX3OAIss oypkqz7nk8E= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 8741997977; Mon, 2 Dec 2019 01:13:20 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id BCBF497976; Mon, 2 Dec 2019 01:13:17 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Todd Zullinger Cc: Andreas Schwab , =?utf-8?B?w4Z2YXIgQXJuZmo=?= =?utf-8?B?w7Zyw7A=?= Bjarmason , git@vger.kernel.org, Carlo Marcelo Arenas =?utf-8?Q?Bel=C3=B3n?= , Beat Bolli , Johannes Schindelin , Jeff King Subject: Re: [PATCH] t7812: expect failure for grep -i with invalid UTF-8 data References: <20191130004653.8794-1-tmz@pobox.com> <87a78ddc9o.fsf@hase.home> <20191201183203.GC17681@pobox.com> Date: Sun, 01 Dec 2019 22:13:15 -0800 In-Reply-To: <20191201183203.GC17681@pobox.com> (Todd Zullinger's message of "Sun, 1 Dec 2019 13:32:03 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: D5031C2C-14CA-11EA-9FF6-8D86F504CC47-77302942!pb-smtp21.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Todd Zullinger writes: > After Andreas' missing redirect fix, that still fails on > s390x (not surprisingly). But now systems with JIT enabled > fail at: > ... > Here's how I changed the commit message locally. I was > going to wait a day or so for any other feedback on the > actual test changes, being a holiday weekend in the US (and > more generally a weekend). > > 1: d9aeaf0c98 ! 1: d0c083db78 t7812: expect failure for grep -i with invalid UTF-8 data > @@ Commit message > 8a5999838e (grep: stess test PCRE v2 on invalid UTF-8 data, 2019-07-26) > and 870eea8166 (grep: do not enter PCRE2_UTF mode on fixed matching, > 2019-07-26) they lacked a redirect which caused them to falsely succeed > - on most architectures. They failed on big-endian arches where the test > - never reached the portion which was missing the redirect. > + on most systems. The 'grep -i' test failed on systems where JIT was > + disabled as it never reached the portion which was missing the redirect. > > - A recent patch add the missing redirect and exposed the fact that the > - 'PCRE v2: grep non-ASCII from invalid UTF-8 data with -i' test fails on > - all architectures. > + A recent patch added the missing redirect and exposed the fact that the > + 'PCRE v2: grep non-ASCII from invalid UTF-8 data with -i' test fails > + regardless of whether JIT is enabled. > > Based on the final paragraph in in 870eea8166: > > Thanks for pointing out the proper reasoning to use in the > commit message Andreas. I hadn't looked at the Fedora pcre2 > package to see that it explicitly disables JIT on s390x. OK. I locally edited the log message to match the above. I guess this forms an integral part of a topic that Andreas started with the "missing redirects" fix, so let me queue your patch directly on the same topic branch, without creating a separate one. Thanks, both.