From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: "András Kucsma via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "András Kucsma" <r0maikx02b@gmail.com>
Subject: Re: [PATCH v2] Fix dir sep handling of GIT_ASKPASS on Windows
Date: Thu, 26 Mar 2020 14:16:51 -0700 [thread overview]
Message-ID: <xmqqftduizp8.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200325163540.vdc7l72fke7yqryb@tb-raspi4> ("Torsten Bögershausen"'s message of "Wed, 25 Mar 2020 17:35:40 +0100")
Torsten Bögershausen <tboegi@web.de> writes:
>> On Windows with git installed through cygwin, GIT_ASKPASS failed to run
>
> My understanding is, that git under cygwin needs this patch (so to say),
> but isn't it so, that even Git for Windows has the same issue ?
> The headline of the patch and the indicate so.
Yes, I agree that the commit is mistitled. It is not specific to
Windows (it only is Cygwin, as the support for native Windows goes a
separate codepath), and it is not specific to GIT_ASKPASS, either.
next prev parent reply other threads:[~2020-03-26 21:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 21:13 [PATCH] Fix dir sep handling of GIT_ASKPASS on Windows András Kucsma via GitGitGadget
2020-03-24 20:51 ` Junio C Hamano
2020-03-25 13:45 ` [PATCH v2] " András Kucsma via GitGitGadget
2020-03-25 16:35 ` Torsten Bögershausen
2020-03-25 17:09 ` András Kucsma
2020-03-26 21:16 ` Junio C Hamano [this message]
2020-03-26 21:14 ` Junio C Hamano
2020-03-27 0:21 ` András Kucsma
2020-03-27 0:36 ` [PATCH v3] run-command: trigger PATH lookup properly on Cygwin András Kucsma via GitGitGadget
2020-03-27 18:04 ` Junio C Hamano
2020-03-27 18:10 ` András Kucsma
2020-03-27 18:41 ` Andreas Schwab
2020-03-27 21:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqftduizp8.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=r0maikx02b@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).