git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, jrnieder@gmail.com, elbrus@debian.org,
	ijackson@chiark.greenend.org.uk, phillip.wood@dunelm.org.uk,
	alban.gruin@gmail.com, Johannes.Schindelin@gmx.de,
	Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] sequencer: honor GIT_REFLOG_ACTION
Date: Wed, 01 Apr 2020 13:46:21 -0700	[thread overview]
Message-ID: <xmqqftdn53z6.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.746.git.git.1585773096145.gitgitgadget@gmail.com> (Elijah Newren via GitGitGadget's message of "Wed, 01 Apr 2020 20:31:35 +0000")

"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Elijah Newren <newren@gmail.com>
>
> There is a lot of code to honor GIT_REFLOG_ACTION throughout git,
> including some in sequencer.c; unfortunately, reflog_message() and its
> callers ignored it.  Instruct reflog_message() to check the existing
> environment variable, and use it when present as an override to
> action_name().
>
> Also restructure pick_commits() to only temporarily modify
> GIT_REFLOG_ACTION for a short duration and then restore the old value,

Yeah, I was wondering what you'd be doing about that setenv().  The
code around there looks good.  I briefly wondered what would happen
when the environment variable is totally unset upon entry, but then
we'd have the fallback value of action_name(opts) in there, so we
won't have a risk of running xstrdup(NULL).


  reply	other threads:[~2020-04-01 20:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01 20:31 [PATCH] sequencer: honor GIT_REFLOG_ACTION Elijah Newren via GitGitGadget
2020-04-01 20:46 ` Junio C Hamano [this message]
2020-04-01 23:29 ` Ian Jackson
2020-04-02  5:15   ` Elijah Newren
2020-04-02  9:39     ` Phillip Wood
2020-04-02 17:40       ` Elijah Newren
2020-04-02  9:25 ` Phillip Wood
2020-04-02 17:01   ` Elijah Newren
2020-04-02 19:05     ` Phillip Wood
2020-04-07 14:50       ` Johannes Schindelin
2020-04-07 15:18         ` Elijah Newren
2020-04-07 22:37           ` Johannes Schindelin
2020-04-07 23:05             ` Junio C Hamano
2020-04-07 16:59 ` [PATCH v2] " Elijah Newren via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqftdn53z6.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=alban.gruin@gmail.com \
    --cc=elbrus@debian.org \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=ijackson@chiark.greenend.org.uk \
    --cc=jrnieder@gmail.com \
    --cc=newren@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).