From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 3C8C61F55B for ; Tue, 12 May 2020 21:10:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731260AbgELVKD (ORCPT ); Tue, 12 May 2020 17:10:03 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:56097 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726324AbgELVKD (ORCPT ); Tue, 12 May 2020 17:10:03 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 709CDD3EF4; Tue, 12 May 2020 17:10:01 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=oSI6d0ZaRxfNqglSrC5cYqkYI3I=; b=P2030i jMVIJ4xSXloeH4EgYEEReaRBfrdXvSbEruKw6z6n+YErnlHyLSDUNcndA4mHAHQi 5No0ooRy6BvJUCEyeZ3PlZhtODp0u6bUlZMki+A0eBmdrsAjFG8nPkWyESHJF7Lc OPuqlXgbd1ew4wPd3fUau8S8yfypf//XVyy/U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=dyym2HkBwD5vkq6QBl2+sFESM4dhq8+o VcxP7g1XTQ+9Lo0my4Evr9aUYubayOZelqnfxB5HQDwWyNk6KmL24mOZOWrTj2RK hjC6bocaD2FHxJwMT+Rgg5tM4heAU41dCRBL3McYN+iy2GlUHevmN7M+lMCsrEtM yuNEoIhSZtQ= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 59BA9D3EF3; Tue, 12 May 2020 17:10:01 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.99.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 5ADBAD3EF0; Tue, 12 May 2020 17:09:58 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Sibi Siddharthan via GitGitGadget" Cc: git@vger.kernel.org, Sibi Siddharthan Subject: Re: [PATCH v2 09/11] cmake: relocated script file contrib/buildsystems References: <9c674372fb58aa42e339c0a96c432283c4b0a894.1589302255.git.gitgitgadget@gmail.com> Date: Tue, 12 May 2020 14:09:56 -0700 In-Reply-To: <9c674372fb58aa42e339c0a96c432283c4b0a894.1589302255.git.gitgitgadget@gmail.com> (Sibi Siddharthan via GitGitGadget's message of "Tue, 12 May 2020 16:50:52 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: EF95BF14-9494-11EA-A54E-B0405B776F7B-77302942!pb-smtp20.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Sibi Siddharthan via GitGitGadget" writes: > From: Sibi Siddharthan > > The CMake script has been relocated to contrib/buildsystems. > The changes made to the script involves pointing to correct location > of the source files. This does match what the list agreed to do. Why isn't this done as part of [01/11]? If there is no technical reason not to, I'd strongly prefer to see it done from the very beginning. The same comment applies to the next step. Thanks. > Signed-off-by: Sibi Siddharthan > --- > .../buildsystems/CMakeLists.txt | 76 +++++++++++-------- > 1 file changed, 45 insertions(+), 31 deletions(-) > rename CMakeLists.txt => contrib/buildsystems/CMakeLists.txt (92%)