From: Junio C Hamano <gitster@pobox.com>
To: Aaron Schrab <aaron@schrab.com>
Cc: Ash Holland <ash@sorrel.sh>, git@vger.kernel.org
Subject: Re: `git describe --dirty` doesn't consider untracked files to be dirty
Date: Tue, 08 Sep 2020 16:59:20 -0700 [thread overview]
Message-ID: <xmqqft7rx1k7.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200908231652.GC1014@pug.qqx.org> (Aaron Schrab's message of "Tue, 8 Sep 2020 19:16:52 -0400")
Aaron Schrab <aaron@schrab.com> writes:
> It's perhaps worth noting that submodules are already considered dirty
> when untracked files are added:
>
> $ git diff vim/bundle/fugitive
>
> $ echo foo >vim/bundle/fugitive/foo
>
> $ git diff vim/bundle/fugitive
> diff --git i/vim/bundle/fugitive w/vim/bundle/fugitive
> --- i/vim/bundle/fugitive
> +++ w/vim/bundle/fugitive
> @@ -1 +1 @@
> -Subproject commit caf3b1d5696e8d39a905e48f1e89d8c0c565168c
> +Subproject commit caf3b1d5696e8d39a905e48f1e89d8c0c565168c-dirty
It gives one vote for (1) to the part you did not quote from the
message you are responding to, which was:
>> I do not think this is something we want to hide behind a
>> configuration knob, but I am undecided between (1) declare that this
>> is a bug and change the behaviour of "--dirty" and (2) declare that
>> we discovered another useful behaviour and add a new option next to
>> "--dirty".
I tend to agree the consistency with that behaviour would be more
useful. The discrepanthy shows the relative age of features and how
our thinking has changed over time ;-)
next prev parent reply other threads:[~2020-09-08 23:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 9:04 `git describe --dirty` doesn't consider untracked files to be dirty Ash Holland
2020-09-08 7:40 ` Raymond E. Pasco
2020-09-08 16:33 ` Junio C Hamano
2020-09-08 23:16 ` Aaron Schrab
2020-09-08 23:59 ` Junio C Hamano [this message]
2020-09-19 18:12 ` Junio C Hamano
2020-09-20 0:17 ` Ash Holland
2020-09-20 1:46 ` Junio C Hamano
2020-09-20 2:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqft7rx1k7.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=aaron@schrab.com \
--cc=ash@sorrel.sh \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).