git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: git@vger.kernel.org, Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH v2 0/1] teach format.useAutoBase "whenAble" option
Date: Thu, 01 Oct 2020 15:21:56 -0700	[thread overview]
Message-ID: <xmqqft6xbn97.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201001214653.1609405-1-jacob.e.keller@intel.com> (Jacob Keller's message of "Thu, 1 Oct 2020 14:46:52 -0700")

Jacob Keller <jacob.e.keller@intel.com> writes:

> From: Jacob Keller <jacob.keller@gmail.com>
>
> This is a v2 of [1] to address comments on the mailing list. Primarily the
> change is to remove the option for --base=if-able, since it is not as useful
> as the configuration option. If we think it is desirable, adding back a
> whenable or whenAble option is easy enough.

The simplification is a great thing to do, and I agree with the
rationale you wrote ...

>     +    This does mean that a user cannot request this optional base commit
>     +    generation from the command line. However, this is likely not too
>     +    valuable. If the user requests base information manually, they will be
>     +    immediately informed of the failure to acquire a suitable base commit.
>     +    This allows the user to make an informed choice about whether to
>     +    continue the format.

... which is sensible.

Thanks, will queue.

      parent reply	other threads:[~2020-10-01 22:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01 21:46 [PATCH v2 0/1] teach format.useAutoBase "whenAble" option Jacob Keller
2020-10-01 21:46 ` [PATCH v2 1/1] format-patch: " Jacob Keller
2020-10-01 22:21 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqft6xbn97.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jacob.keller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).