From: Junio C Hamano <gitster@pobox.com>
To: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>,
Derrick Stolee <stolee@gmail.com>, Jeff King <peff@peff.net>,
Derrick Stolee <derrickstolee@github.com>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH v4 2/2] commit-graph: don't write commit-graph when disabled
Date: Fri, 09 Oct 2020 14:12:59 -0700 [thread overview]
Message-ID: <xmqqft6nrtlw.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <4439e8ae8fdc9abf28df29d3038a1483d9084cf2.1602276832.git.gitgitgadget@gmail.com> (Derrick Stolee via GitGitGadget's message of "Fri, 09 Oct 2020 20:53:52 +0000")
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> + if (!the_repository->settings.core_commit_graph) {
> + warning(_("attempting to write a commit-graph, but 'core.commitGraph' is disabled"));
> + return 0;
> + }
Makes sense. We probably would want to short-circuit invocation of
commit-graph related tasks in the maintenance by checking the
feature, if we are not already doing so.
Thanks.
next prev parent reply other threads:[~2020-10-09 21:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 13:56 [PATCH] commit-graph: ignore duplicates when merging layers Derrick Stolee via GitGitGadget
2020-10-08 14:15 ` Taylor Blau
2020-10-08 14:29 ` Derrick Stolee
2020-10-08 14:59 ` [PATCH v2] " Derrick Stolee via GitGitGadget
2020-10-08 15:04 ` [PATCH v3] " Derrick Stolee via GitGitGadget
2020-10-08 15:53 ` Jeff King
2020-10-08 16:26 ` Derrick Stolee
2020-10-08 16:42 ` Taylor Blau
2020-10-08 16:43 ` Jeff King
2020-10-09 20:53 ` [PATCH v4 0/2] " Derrick Stolee via GitGitGadget
2020-10-09 20:53 ` [PATCH v4 1/2] " Derrick Stolee via GitGitGadget
2020-10-09 20:53 ` [PATCH v4 2/2] commit-graph: don't write commit-graph when disabled Derrick Stolee via GitGitGadget
2020-10-09 21:12 ` Junio C Hamano [this message]
2020-10-09 21:17 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqft6nrtlw.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).