From: Junio C Hamano <gitster@pobox.com>
To: Tom Saeger <tom.saeger@oracle.com>
Cc: Derrick Stolee <stolee@gmail.com>, git@vger.kernel.org
Subject: Re: should git maintenance prefetch be taught to honor remote.fetch refspec?
Date: Fri, 02 Apr 2021 15:09:01 -0700 [thread overview]
Message-ID: <xmqqft082vb6.fsf@gitster.g> (raw)
In-Reply-To: <20210402213909.zuyyqqisvq7gjcxo@brm-x62-17.us.oracle.com> (Tom Saeger's message of "Fri, 2 Apr 2021 15:39:09 -0600")
Tom Saeger <tom.saeger@oracle.com> writes:
> On Fri, Apr 02, 2021 at 05:07:09PM -0400, Derrick Stolee wrote:
>> On 4/2/2021 4:43 PM, Derrick Stolee wrote:
>> > On 4/2/2021 2:27 PM, Tom Saeger wrote:
>> >> generally isn't it still changing the right-hand side of refspec?
>> >>
>> >> replacing ":refs/" with ":refs/prefetch/"
>> >
>> > Right, this substring replacement might be easiest to achieve. The
>> > 'struct refspec' doesn't make it incredibly easy. Perhaps skipping
>> > the refspec parsing and just doing that substring swap directly from
>> > the config value might be the best approach.
>> >
>> >> This would still work for refspecs with negative patterns right?
>> >
>> > One of the issues is that negative patterns have no ":refs/"
>> > substring.
>> >
>> > The other issue is that exact matches (no "*") have an exact
>> > string in the destination, too, so replacing the _entire_
>> > destination with "refs/prefetch/<remote>/*" breaks the refspec.
>> > I think the substring approach will still work here.
>>
>> I updated my branch with the substring approach, which is
>> probably the better solution. Please give it a try. I don't
>> expect that change to help the FreeBSD build, but we will see.
>
>
> This worked for all the scenarios I tried, which had both negatives and
> multi remote fetch values.
>
> Looks good!
>
> Reviewed-by: Tom Saeger <tom.saeger@oracle.com>
That sounds more like tested-by, but anyway, thanks for working well
together.
>
>>
>> > [1] https://github.com/gitgitgadget/git/pull/924
>> > [2] https://github.com/gitgitgadget/git/pull/924/checks?check_run_id=2256079534
>>
>> Thanks,
>> -Stolee
next prev parent reply other threads:[~2021-04-02 22:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 18:49 should git maintenance prefetch be taught to honor remote.fetch refspec? Tom Saeger
2021-04-01 19:07 ` Derrick Stolee
2021-04-01 19:42 ` Tom Saeger
2021-04-01 20:14 ` Junio C Hamano
2021-04-01 22:11 ` Tom Saeger
2021-04-01 22:25 ` Derrick Stolee
2021-04-02 18:27 ` Tom Saeger
2021-04-02 20:43 ` Derrick Stolee
2021-04-02 21:07 ` Derrick Stolee
2021-04-02 21:39 ` Tom Saeger
2021-04-02 22:09 ` Junio C Hamano [this message]
2021-04-02 22:27 ` Tom Saeger
2021-04-02 21:15 ` Tom Saeger
2021-04-02 21:19 ` Junio C Hamano
2021-04-02 21:33 ` Tom Saeger
2021-04-04 20:25 ` Derrick Stolee
2021-04-04 23:10 ` Junio C Hamano
2021-04-05 13:20 ` Derrick Stolee
2021-04-05 18:48 ` Junio C Hamano
2021-04-05 20:38 ` Tom Saeger
2021-04-05 20:47 ` Junio C Hamano
2021-04-05 20:49 ` Derrick Stolee
2021-04-05 20:50 ` Tom Saeger
2021-04-05 20:54 ` Derrick Stolee
2021-04-02 22:32 ` Eric Sunshine
2021-04-03 20:21 ` Tom Saeger
2021-04-03 22:41 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqft082vb6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
--cc=tom.saeger@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).