From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/9] leftover bits from symlinked gitattributes, etc topics
Date: Mon, 03 May 2021 14:36:06 +0900 [thread overview]
Message-ID: <xmqqfsz48jll.fsf@gitster.g> (raw)
In-Reply-To: <YI12hK4X/gfl3u29@coredump.intra.peff.net> (Jeff King's message of "Sat, 1 May 2021 11:40:52 -0400")
Jeff King <peff@peff.net> writes:
> A while back, I had a topic[1] that treated symlinked .gitattributes
> (and .gitignore and .mailmap) the same as .gitmodules: forbidding them
> in the index, complaining about them via fsck, etc.
>
> In the end, we decided not to do that[2], and instead just open the
> files with O_NOFOLLOW instead. As I said in that thread, we could
> salvage some of the cleanups, fsck checks, and docs from the original
> topic. So here that is. (The new topic is in master but not yet
> released; so while this is not strictly a bug-fix for an existing topic,
> it would be good to get especially the doc improvements into the same
> release).
Thanks.
> [1] https://lore.kernel.org/git/20201005071751.GA2290770@coredump.intra.peff.net/
> [2] https://lore.kernel.org/git/YDiWs6yyv3U9YvC2@coredump.intra.peff.net/
>
> The patches are:
>
> [1/9]: t7415: remove out-dated comment about translation
> [2/9]: fsck_tree(): fix shadowed variable
> [3/9]: fsck_tree(): wrap some long lines
>
> These three are really independent fixes and cleanups, that could be
> taken separately.
>
> [4/9]: t7415: rename to expand scope
> [5/9]: t7450: test verify_path() handling of gitmodules
> [6/9]: t7450: test .gitmodules symlink matching against obscured names
>
> These three are just cleaning up and improving the tests for the
> existing handling of the .gitmodules symlinks.
>
> [7/9]: t0060: test ntfs/hfs-obscured dotfiles
> [8/9]: fsck: warn about symlinked dotfiles we'll open with O_NOFOLLOW
>
> These two extend fsck checks (warnings, not errors) to the new
> files. I think this is an improvement, but I could be persuaded
> otherwise (and these two could be dropped independent of the rest).
>
> [9/9]: docs: document symlink restrictions for dot-files
>
> And this covers documentation for all of the files (including
> .gitmodules).
>
> Documentation/gitattributes.txt | 7 ++
> Documentation/gitignore.txt | 5 +
> Documentation/gitmailmap.txt | 7 ++
> Documentation/gitmodules.txt | 8 ++
> cache.h | 1 +
> fsck.c | 84 ++++++++++---
> fsck.h | 3 +
> path.c | 5 +
> t/helper/test-path-utils.c | 46 +++++--
> t/t0060-path-utils.sh | 30 +++++
> ...ule-names.sh => t7450-bad-git-dotfiles.sh} | 116 +++++++++++++-----
> utf8.c | 5 +
> utf8.h | 1 +
> 13 files changed, 257 insertions(+), 61 deletions(-)
> rename t/{t7415-submodule-names.sh => t7450-bad-git-dotfiles.sh} (70%)
>
> -Peff
next prev parent reply other threads:[~2021-05-03 5:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 15:40 [PATCH 0/9] leftover bits from symlinked gitattributes, etc topics Jeff King
2021-05-01 15:41 ` [PATCH 1/9] t7415: remove out-dated comment about translation Jeff King
2021-05-03 9:46 ` Ævar Arnfjörð Bjarmason
2021-05-03 20:29 ` Jeff King
2021-05-01 15:41 ` [PATCH 2/9] fsck_tree(): fix shadowed variable Jeff King
2021-05-03 11:15 ` Ævar Arnfjörð Bjarmason
2021-05-03 20:13 ` Jeff King
2021-05-04 10:10 ` Ævar Arnfjörð Bjarmason
2021-05-01 15:41 ` [PATCH 3/9] fsck_tree(): wrap some long lines Jeff King
2021-05-03 11:22 ` Ævar Arnfjörð Bjarmason
2021-05-03 20:23 ` Jeff King
2021-05-01 15:42 ` [PATCH 4/9] t7415: rename to expand scope Jeff King
2021-05-01 15:42 ` [PATCH 5/9] t7450: test verify_path() handling of gitmodules Jeff King
2021-05-01 18:55 ` Eric Sunshine
2021-05-01 19:03 ` Eric Sunshine
2021-05-03 19:39 ` Jeff King
2021-05-03 10:12 ` Ævar Arnfjörð Bjarmason
2021-05-03 20:32 ` Jeff King
2021-05-01 15:42 ` [PATCH 6/9] t7450: test .gitmodules symlink matching against obscured names Jeff King
2021-05-01 15:42 ` [PATCH 7/9] t0060: test ntfs/hfs-obscured dotfiles Jeff King
2021-05-01 15:43 ` [PATCH 8/9] fsck: warn about symlinked dotfiles we'll open with O_NOFOLLOW Jeff King
2021-05-01 15:43 ` [PATCH 9/9] docs: document symlink restrictions for dot-files Jeff King
2021-05-01 19:16 ` Eric Sunshine
2021-05-03 20:33 ` Jeff King
2021-05-03 5:36 ` Junio C Hamano [this message]
2021-05-03 20:42 ` [PATCH v2 0/9] leftover bits from symlinked gitattributes, etc topics Jeff King
2021-05-03 20:43 ` [PATCH v2 1/9] t7415: remove out-dated comment about translation Jeff King
2021-05-03 20:43 ` [PATCH v2 2/9] fsck_tree(): fix shadowed variable Jeff King
2021-05-03 20:43 ` [PATCH v2 3/9] fsck_tree(): wrap some long lines Jeff King
2021-05-03 20:43 ` [PATCH v2 4/9] t7415: rename to expand scope Jeff King
2021-05-03 20:43 ` [PATCH v2 5/9] t7450: test verify_path() handling of gitmodules Jeff King
2021-05-03 20:43 ` [PATCH v2 6/9] t7450: test .gitmodules symlink matching against obscured names Jeff King
2021-05-03 20:43 ` [PATCH v2 7/9] t0060: test ntfs/hfs-obscured dotfiles Jeff King
2021-05-03 20:43 ` [PATCH v2 8/9] fsck: warn about symlinked dotfiles we'll open with O_NOFOLLOW Jeff King
2021-05-03 20:43 ` [PATCH v2 9/9] docs: document symlink restrictions for dot-files Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfsz48jll.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).