git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: git@vger.kernel.org, felipe.contreras@gmail.com
Subject: Re: [PATCH v3] *: fix typos which duplicate a word
Date: Mon, 14 Jun 2021 10:11:19 +0900	[thread overview]
Message-ID: <xmqqfsxl1c94.fsf@gitster.g> (raw)
In-Reply-To: <20210611111850.3430523-1-rybak.a.v@gmail.com> (Andrei Rybak's message of "Fri, 11 Jun 2021 13:18:50 +0200")

Andrei Rybak <rybak.a.v@gmail.com> writes:

> Fix typos in documentation, code comments, and RelNotes which repeat
> various words.  In trivial cases, just delete the duplicated word and
> rewrap text, if needed.  Reword the affected sentence in
> Documentation/RelNotes/1.8.4.txt for it to make sense.

Thanks.  I usually avoid touching published release notes (it is not
like we'd issue 1.8.4.1 maintenance release to apply this typofix),
but as you spent time to fix them all, and as we spent time to review
the changes, let's take all of them.

>   * Invocations of "git checkout" used internally by "git rebase" were
> -   counted as "checkout", and affected later "git checkout -" to the
> +   counted as "checkout", and affected later "git checkout -" which took
>     the user to an unexpected place.
>     (merge 3bed291 rr/rebase-checkout-reflog later to maint).

I think this one actually wanted to say "affected later X to take
the user to an unexpected place", but ", which" is OK, too.

Thanks.

      reply	other threads:[~2021-06-14  1:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 10:26 [PATCH] " Andrei Rybak
2021-06-09 15:28 ` Eric Sunshine
2021-06-09 17:31 ` Felipe Contreras
2021-06-10  7:24 ` [PATCH v2] *: " Andrei Rybak
2021-06-10 14:46   ` Felipe Contreras
2021-06-10 23:59   ` Junio C Hamano
2021-06-11  9:31     ` Andrei Rybak
2021-06-11 11:18 ` [PATCH v3] " Andrei Rybak
2021-06-14  1:11   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfsxl1c94.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=rybak.a.v@gmail.com \
    --subject='Re: [PATCH v3] *: fix typos which duplicate a word' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.version-control.git
	nntp://ie5yzdi7fg72h7s4sdcztq5evakq23rdt33mfyfcddc5u3ndnw24ogqd.onion/inbox.comp.version-control.git
	nntp://4uok3hntl7oi7b4uf4rtfwefqeexfzil2w6kgk2jn5z2f764irre7byd.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git