From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <johannes.schindelin@gmail.com>
Cc: rsbecker@nexbridge.com, git@vger.kernel.org
Subject: Re: [Bug] wrapper.c uses unportable unsetenv
Date: Fri, 29 Oct 2021 14:57:52 -0700 [thread overview]
Message-ID: <xmqqfssjijdr.fsf@gitster.g> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2110292348530.56@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Fri, 29 Oct 2021 23:50:38 +0200 (CEST)")
Johannes Schindelin <johannes.schindelin@gmail.com> writes:
> @@ -24,4 +24,5 @@ void gitunsetenv (const char *name)
> ++dst;
> }
> environ[dst] = NULL;
> + return 0;
> }
Yup, that hunk (with a blank before the "return") is already in my
"real" version. Thanks for spotting.
prev parent reply other threads:[~2021-10-29 21:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 20:14 [Bug] wrapper.c uses unportable unsetenv rsbecker
2021-10-29 20:35 ` Junio C Hamano
2021-10-29 20:49 ` rsbecker
2021-10-29 21:10 ` rsbecker
2021-10-29 21:42 ` Junio C Hamano
2021-10-29 21:50 ` Johannes Schindelin
2021-10-29 21:57 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfssjijdr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmail.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).