From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=0.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 7B3041F852 for ; Thu, 10 Feb 2022 18:04:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbiBJSEp (ORCPT ); Thu, 10 Feb 2022 13:04:45 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:33424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233277AbiBJSEn (ORCPT ); Thu, 10 Feb 2022 13:04:43 -0500 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83732100A for ; Thu, 10 Feb 2022 10:04:44 -0800 (PST) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id ABAA81080BF; Thu, 10 Feb 2022 13:04:43 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=eEcneBcYXRadzsA43JV6U6KrCJ3YFxfxvVAyGk ih1To=; b=cafokg5sRUbQDHZBr4V6ZSuvqqttN4Yk2QaboTVI9/+k7nsoqdc2uh IIKMzWDfY5ytZoklKCnAp9hM4kex953R/Pf43t2vqJ54vgcZe95qe5AmCHb8FzvO L2YKjQhcbxZX72jWACpWrudw8NTyfHpbFTLdTe44pYhD2RDe6ZUeU= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id A2DE31080BE; Thu, 10 Feb 2022 13:04:43 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.185.212.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 08CED1080BD; Thu, 10 Feb 2022 13:04:42 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Patrick Steinhardt Cc: git@vger.kernel.org, Taylor Blau , Derrick Stolee , Christian Couder Subject: Re: [PATCH v3 0/2] fetch: speed up mirror-fetches with many refs References: Date: Thu, 10 Feb 2022 10:04:41 -0800 In-Reply-To: (Patrick Steinhardt's message of "Thu, 10 Feb 2022 13:28:01 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: EC4BBC06-8A9B-11EC-94D6-CB998F0A682E-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org 1Patrick Steinhardt writes: > this is the third version of my patch series which aimn to speed up > mirror-fetches in repos with huge amounts of refs. Again, the only > change compared to v2 is a change in commit messages: Chris has rightly > pointed out that the benchmarks were a bit confusing, so I've updated > them to hopefully be less so. > > Thanks for your feedback! > Patrick > > Patrick Steinhardt (2): > fetch-pack: use commit-graph when computing cutoff > fetch: skip computing output width when not printing anything Both changes are based on quite sensible idea. If we have precomputed dates for each commit, it makes sense to look it up before parsing the commit. If we are not preparing output, there is no point in computing the output width. Very simple and potentially effective. Will queue. Thanks.