From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 8FD661F4DA for ; Thu, 20 Oct 2022 01:37:10 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="pj1+HKnS"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231171AbiJTB3j (ORCPT ); Wed, 19 Oct 2022 21:29:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231285AbiJTB3c (ORCPT ); Wed, 19 Oct 2022 21:29:32 -0400 Received: from pb-smtp20.pobox.com (pb-smtp20.pobox.com [173.228.157.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCD051CB526 for ; Wed, 19 Oct 2022 18:28:40 -0700 (PDT) Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 4FD141C4530; Wed, 19 Oct 2022 21:21:45 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=zuPmt0x8yufmjNeME/WSf8EluRbLE7Sacp4XCu JLRZ4=; b=pj1+HKnSTUbuBSVsCvcZkTvsHQtQiDWcXl+RyTTGQ6qWMKgtPaizsT lltTT65ISkIwhSrdR1N3YW2hbwv2DOnNsNvmPcJQsaxvQsK8Ul4G9HG25SxempTN pN9JhhlscQTB/DAhHDI58Fpvk//xLOnUT7cOF6OoOWohRn3vHrcm4= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 4817E1C452F; Wed, 19 Oct 2022 21:21:45 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 7E10A1C452E; Wed, 19 Oct 2022 21:21:42 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Heather Lapointe Cc: Heather Lapointe via GitGitGadget , git@vger.kernel.org, =?utf-8?Q?Ren=C3=A9?= Scharfe , Taylor Blau Subject: Re: [PATCH v3 0/9] archive: Add --recurse-submodules to git-archive command References: Date: Wed, 19 Oct 2022 18:21:41 -0700 In-Reply-To: (Junio C. Hamano's message of "Wed, 19 Oct 2022 13:44:00 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 8E011E08-5015-11ED-85C3-C2DA088D43B2-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: >> I personally doubt it is generally a good idea, as it sets a bad >> pattern that tempts unsuspecting users to blindly copy and paste it >> to their $HOME/.gitconfig without realizing what its ramifications >> are, but the easiest workaround may be to mimic what was done in >> t/lib-submodule-update.sh that sets protocol.file.allow >> configuration knob globally. > > I'll queue this at the tip of your topic when I rebuild 'seen' for > today's integration run. > > t/t1023-tree-read-tree-at.sh | 4 +++- > t/t5005-archive-submodules.sh | 7 ++++--- > 2 files changed, 7 insertions(+), 4 deletions(-) It seems to have cleared the "submodule tests no longer can use submodules with file:// without tweaking the config" issue I saw earlier. It seems to give us a segfault in win+VS test, though. https://github.com/git/git/actions/runs/3285647856/jobs/5413033844#step:5:245 Thanks.