From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [IPv6:2604:1380:40f1:3f00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C9CB91F44D for ; Tue, 2 Apr 2024 17:24:38 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=LNa7yfOQ; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0AC65B26D3F for ; Tue, 2 Apr 2024 17:24:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A51DF15AAC2; Tue, 2 Apr 2024 17:23:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="LNa7yfOQ" Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF67615A48A for ; Tue, 2 Apr 2024 17:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.228.157.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712078631; cv=none; b=hh9Bp+gYwbhhIhcxECyMCn6aAkhyGML/FBC22l/dxWpuZkNVZiXFhNdJ8BQAepmWTHBXLkQFTdv226/S0CFSItfIS4J0oU5a8CUmSCO88PtZGkhcXjUgLmGYuXT9nLdaVP1Vo53jTKoOua0qOxg7Dg+AODYm1J++T/sOt6su450= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712078631; c=relaxed/simple; bh=NKAaZJhtbYXD0cjk4zOScrtgk4Lph+lHTYuAZntDyKY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Cq7gOCZx0G5FI+RtrSS0UX08GaAH36ZnjRazPc2JJc684va1rn9XosLpwkAmFY/ILSD+3AW92J8akFblXn/9LzxffxUmUlX/rq8VAjMPIWGNhRgz4yVJhDm4fxAl4+Pkhw0u5mqODiFnrMEMj7egh7ImhS1w8dqQ31JVayMGWs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=LNa7yfOQ; arc=none smtp.client-ip=173.228.157.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 6D59427165; Tue, 2 Apr 2024 13:23:49 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=NKAaZJhtbYXD0cjk4zOScrtgk4Lph+lHTYuAZn tDyKY=; b=LNa7yfOQrihfJF8x4M6xmZySB9beTbXby4O9uVsAyRhcRhoXnCHlmD yPvz8oHujefDpd1CiJVK8s3FFm78PPstR3trkyGtD9O6v2nR1iMcBvsYYAHn81Qm QgIH1jP+65KXrBxWeaO4mXwhDYRQuatDqY6c0gmsIb0RuZ6Y2aRns= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 6532327164; Tue, 2 Apr 2024 13:23:49 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.139.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 6B60A27163; Tue, 2 Apr 2024 13:23:45 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Patrick Steinhardt Cc: Justin Tobler via GitGitGadget , git@vger.kernel.org, Karthik Nayak , Justin Tobler Subject: Re: [PATCH v3 1/3] reftable/stack: add env to disable autocompaction In-Reply-To: (Patrick Steinhardt's message of "Tue, 2 Apr 2024 09:23:45 +0200") References: <2fdd8ea11331da13ec56d511fe4cadd47544419f.1711685809.git.gitgitgadget@gmail.com> Date: Tue, 02 Apr 2024 10:23:43 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: C27BF28C-F115-11EE-866B-A19503B9AAD1-77302942!pb-smtp21.pobox.com Patrick Steinhardt writes: >> - if (!add->stack->disable_auto_compact) >> + if (!add->stack->disable_auto_compact && !git_env_bool("GIT_TEST_REFTABLE_NO_AUTOCOMPACTION", 0)) >> err = reftable_stack_auto_compact(add->stack); > > The double-negation in `GIT_TEST_REFTABLE_NO_AUTOCOMPACTION=false` may be > somewhat hard to parse. Should we rename this to > `GIT_TEST_REFTABLE_AUTO_COMPACTION` with a default value of `1`? Sounds like a nice improvement. Also the overlong line should be folded. Thanks.