From: Junio C Hamano <gitster@pobox.com>
To: "Galan Rémi" <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Cc: Git List <git@vger.kernel.org>,
Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag.grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCHv6 1/3] git-rebase -i: add command "drop" to remove a commit
Date: Tue, 23 Jun 2015 13:37:34 -0700 [thread overview]
Message-ID: <xmqqegl2cga9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqwpyucjj1.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Tue, 23 Jun 2015 12:27:30 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Galan Rémi <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:
>
>> +test_rebase_end () {
>> + test_when_finished "git checkout master &&
>> + git branch -D $1 &&
>
> Is this one guaranteed to succeed? Do we want to consider it a
> failure to remove "$1" (e.g. dropTest)?
>
> $ git branch -D no-such-branch ; echo $?
> error: branch 'no-such-branch' not found.
> 1
>
> If dropTest branch did not exist before the test that begins with
> a call to this function, what happens?
>
> Besides, a function that must be called at the beginning of a test
> piece has a name that ends with _end? That sounds funny, no?
Ah, scratch this last paragraph. I didn't see this is a
multi-command "when_finished".
But other parts of what I said still stands. For example, even in a
multi-command "when_finished", "git branch -D $1 &&" if the main
body of the test failed to create the branch "$1", that command
would fail and skip the remainder of the clean-up, so the first
point above is still suspect.
prev parent reply other threads:[~2015-06-23 20:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 21:42 [PATCHv6 1/3] git-rebase -i: add command "drop" to remove a commit Galan Rémi
2015-06-22 21:42 ` [PATCHv6 2/3] git rebase -i: warn about removed commits Galan Rémi
2015-06-22 21:42 ` [PATCHv6 3/3] git rebase -i: add static check for commands and SHA-1 Galan Rémi
2015-06-23 19:42 ` Junio C Hamano
2015-06-23 20:35 ` Remi Galan Alfonso
2015-06-23 18:24 ` [PATCHv6 1/3] git-rebase -i: add command "drop" to remove a commit Eric Sunshine
2015-06-23 19:01 ` Remi Galan Alfonso
2015-06-23 19:07 ` Matthieu Moy
2015-06-23 19:18 ` Remi Galan Alfonso
2015-06-23 20:22 ` Matthieu Moy
2015-06-23 20:39 ` Junio C Hamano
2015-06-23 20:47 ` Remi Galan Alfonso
2015-06-23 19:17 ` Eric Sunshine
2015-06-23 19:27 ` Junio C Hamano
2015-06-23 20:08 ` Remi Galan Alfonso
2015-06-23 20:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqegl2cga9.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).